From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4697 invoked from network); 23 Feb 2021 22:20:25 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Feb 2021 22:20:25 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID: Content-Type:MIME-Version:Subject:cc:To:References:From:In-reply-to:Reply-To: Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=5ydWOu2pAP1EUgvNNsS8vPC1D97niXFSWWobGaxJu88=; b=u+iClJyzOEbYI6CrXp+cpprGu6 pDwxG0A5B6bD10i6L4+rB60J4eMenD6mGA6dEa8ywq7Sx6ZH1tFK9MEWDfIuLxirR6ovguPIh1p5H Hq6anGT8XL6XS0Up56l99E2elqhUPV8Gn3M8SgGlb0ic3Tza4zZAzYPtFlgyr7bSMTsEduY6HuIYC VvjtkKl9GI/8428fnAuyZYTyxeSfTcJCHmB5C2ZD/PHNGihVhOY56QeRaQBMdDPtNfZOVcMFssnWQ Pm4i5gQVtLRA0zIVdYBTeyGfFnChjB3na8cAUH9YUQd7dpNxbjIm1BP2FOhpXRhm7t358FJoc0WY7 8dfvZkSQ==; Received: from authenticated user by zero.zsh.org with local id 1lEg2Z-000D0x-4I; Tue, 23 Feb 2021 22:20:23 +0000 Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lEg2E-000Cre-Tc; Tue, 23 Feb 2021 22:20:03 +0000 Received: from [192.168.178.21] (helo=hydra) by mail.kiddle.eu with esmtp(Exim 4.93.0.4) (envelope-from ) id 1lEg2E-0008U6-A9; Tue, 23 Feb 2021 23:20:02 +0100 In-reply-to: <1716143236.98921.1614075094353@mail2.virginmedia.com> From: Oliver Kiddle References: <1716143236.98921.1614075094353@mail2.virginmedia.com> To: Peter Stephenson cc: Zsh workers Subject: Re: Completion script for the ctags program MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32616.1614118802.1@hydra> Date: Tue, 23 Feb 2021 23:20:02 +0100 Message-ID: <32617-1614118802.311486@4BXl.GCVX.2_Vl> X-Seq: 48099 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Peter Stephenson wrote: > Thanks, I'm surprised we don't have one but it looks like we only have etags. I've > submitted it. What you've committed looks garbled with the e-mail pasted into the middle of the function. Indentation can be corrected when committing new functions with minimal effort and without need to note the alteration in ChangeLog etc. I hate doing it later because it breaks the usefulness of git blame so would appreciate if you could make a note to do that upfront. That said, it is better that these get applied quickly rather than missed and forgotten. Which leads me to reconsider that I never applied the patch in 44804 to create a separate contrib directory for completions. I would add "suppport for only some variants of a command" to the criteria. That patch mainly didn't get applied because of the outstanding question of what the directory/configure option should be named. Greg Klanderman replied favouring 'Unsupported' or 'Unmaintained'. I think I prefer 'Contrib' because they aren't necessarily "Unmaintained" and anything beginning with U breaks my habit of expecting C/U/C to complete the directories there with Unix. Any other suggestions/comments on that? Given that we need to correct the file anyway, it is probably not too late in this case. Do you want to fix it or shall I do it when moving it across to the "Contrib" or whatever we call it directory? Oliver