zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh workers <zsh-workers@sunsite.dk>
Subject: Re: configure tests for iconv
Date: Thu, 03 Mar 2005 14:51:13 +0100	[thread overview]
Message-ID: <32626.1109857873@trentino.groupinfra.com> (raw)
In-Reply-To: <200503031126.j23BQmXE002473@news01.csr.com>

Peter wrote:
> OK, Cygwin now converts characters up to and including 0x7f.  After that

Good. Thanks for your help with this.

> Would it be worth changing the error message for that error (the second
> one in the iconv branch) to suggest the error was with the particular
> character, rather than with character sets in general?

When using wctomb() instead of iconv() it actually prints "character not
in range" for that situation so it certainly makes sense that we should
be consistent with that.

Oliver

--- utils.c.bak 2005-03-03 14:45:33.772178204 +0100
+++ utils.c     2005-03-03 14:45:36.562694413 +0100
@@ -3637,7 +3637,7 @@ getkeystring(char *s, int *len, int from
                     count = iconv(cd, &inptr, &inbytes, &t, &outbytes);
                    iconv_close(cd);
                    if (count == (size_t)-1) {
-                        zerr("cannot do charset conversion", NULL, 0);
+                        zerr("character not in range", NULL, 0);
                        *t = '\0';
                        *len = t - buf;
                        return buf;


      reply	other threads:[~2005-03-03 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-24 16:39 Oliver Kiddle
2005-03-01 12:46 ` Peter Stephenson
2005-03-01 18:02   ` Oliver Kiddle
2005-03-02 16:08     ` Peter Stephenson
2005-03-02 17:32       ` Andrey Borzenkov
2005-03-02 18:59         ` Peter A. Castro
2005-03-03 11:10       ` Oliver Kiddle
2005-03-03 11:26         ` Peter Stephenson
2005-03-03 13:51           ` Oliver Kiddle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32626.1109857873@trentino.groupinfra.com \
    --to=okiddle@yahoo.co.uk \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).