From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: PATCH: Yet another _perforce options patch
Date: Fri, 22 Aug 2003 11:20:36 +0100 [thread overview]
Message-ID: <3359.1061547636@csr.com> (raw)
Felix pointed out that completion of global options doesn't take into
account existing options properly.
Also now offers to complete the default port 1666.
Index: Completion/Unix/Command/_perforce
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_perforce,v
retrieving revision 1.12
diff -u -r1.12 _perforce
--- Completion/Unix/Command/_perforce 21 Aug 2003 18:27:19 -0000 1.12
+++ Completion/Unix/Command/_perforce 22 Aug 2003 10:16:38 -0000
@@ -273,8 +273,11 @@
# end of the arguments list, anyway.
for (( i = 2; i < CURRENT; i++ )); do
if [[ $words[i] = -[$argopts_pass$argopts_ignore] ]]; then
- # word with following argument
- if [[ $words[i] = -[$argopts_pass] ]]; then
+ # word with following argument --- check this
+ # is less than the current word, else we are completing
+ # this and shouldn't pass it down
+ if [[ $(( i + 1 )) -lt $CURRENT && \
+ $words[i] = -[$argopts_pass] ]]; then
_perforce_global_options+=(${words[i,i+1]})
fi
(( i++ ))
@@ -912,6 +915,8 @@
_perforce_hosts_ports() {
if compset -P '*:'; then
_ports
+ local expl
+ _wanted ports expl port compadd "$@" 1666
else
# is this -q-able?
_hosts -S :
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070
**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
and/or privileged material.
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is
prohibited.
If you received this in error, please contact the sender and
delete the material from any computer.
**********************************************************************
reply other threads:[~2003-08-22 10:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3359.1061547636@csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).