Bugs in 3.1.2

Bugs in 3.1.2

[Bernd Eggink]

(I'm re-sending this because my first mail seems to have got lost).

1. There's still a minor bug in 'getopts' in 3.1.2. If the options
string contains a ':', a user supplied option ':' will be accepted.
Example:

  # tst
  while getopts ab:c opt
  do; print "option is $opt"; done
    
  tst -:        # prints 'option is :'

The easiest way to avoid this is to declare the option character ':' 
illegal. Here is a patch for "builtin.c":


2393a2394
>       lenoptstr--;
2421c2422
<     if (i == lenoptstr) {
---
>     if (i == lenoptstr || *opch == ':') {


2. 'select' still doesn't check its input correctly. As 'atoi' is used,
any string starting with a valid number is accepted. IMHO it would be
better to use 'strtol' instead and check the delimiting character. This
patch for "loop.c" does it:

123c123
<     char *str, *s;
---
>     char *str, *s, *estr;
126c126
<     int i;
---
>     long i;
172,173c172,173
<       i = atoi(str);
<       if (!i)
---
>       i = strtol(str, &estr, 10);
>       if (!i || *estr)



-- 
Bernd Eggink
Regionales Rechenzentrum der Universitaet Hamburg
eggink@rrz.uni-hamburg.de
http://www.rrz.uni-hamburg.de/eggink/BEggink.html

Re: Bugs in 3.1.2

[Zoltan T. Hidvegi]

Bernd Eggink wrote:
> 2. 'select' still doesn't check its input correctly. As 'atoi' is used,
> any string starting with a valid number is accepted. IMHO it would be
> better to use 'strtol' instead and check the delimiting character. This

I did check this before the release and ksh93, pdksh and bash all have the
same behaviour as zsh.  So four completely different shell with different
source base has the same behaviour.  I'm not convinced that this has to be
changed.

Zoltan

Re: Bugs in 3.1.2

[Bernd Eggink]

(Zoltan T. Hidvegi) wrote:
> 
> Bernd Eggink wrote:
> > 2. 'select' still doesn't check its input correctly. As 'atoi' is used,
> > any string starting with a valid number is accepted. IMHO it would be
> > better to use 'strtol' instead and check the delimiting character. This
> 
> I did check this before the release and ksh93, pdksh and bash all have the
> same behaviour as zsh.  So four completely different shell with different
> source base has the same behaviour. 

I know, but as I told you some time ago, David Korn himself considers
this behaviour a bug... And why not do better than other shells?

Bernd

-- 
Bernd Eggink
Regionales Rechenzentrum der Universitaet Hamburg
eggink@rrz.uni-hamburg.de
http://www.rrz.uni-hamburg.de/eggink/BEggink.html