From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Opening a file descriptor for reading with exec breaks vim shell
Date: Tue, 19 May 2020 18:31:26 +0100 (BST) [thread overview]
Message-ID: <354439768.604804.1589909487014@mail2.virginmedia.com> (raw)
In-Reply-To: <20200517090348.2lomdks3fpmxl433@chazelas.org>
On 17 May 2020 at 10:03 Stephane Chazelas <stephane@chazelas.org> wrote:
> The patch below fixes those, but I have to admit there's a lot
> of the related code in zsh I don't understand, a lot of the
> behaviour I don't understand either. It's possible that patch
> could break things related to clone, zpty, set -m or opening tty
> devices, but it seems to me that some of that is already quite
> broken.
Should really follow up to this...
Actually, I don't think set -m was ever mended; I think it's always
been a bit of an afterthought that sets up a process group, but
doesn't do a lot else. I'd be inclined not to worry about
side effects of this patch unless there's something demonstrably
worse, since it's fixing something you would expect to work
(and that doesn't depend on zsh wizardry).
pws
prev parent reply other threads:[~2020-05-19 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 4:57 Roman Perepelitsa
2020-05-17 9:03 ` Stephane Chazelas
2020-05-18 8:35 ` Roman Perepelitsa
2020-05-19 17:31 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=354439768.604804.1589909487014@mail2.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).