From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15134 invoked from network); 19 May 2020 17:32:15 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 19 May 2020 17:32:15 -0000 Received: (qmail 4786 invoked by alias); 19 May 2020 17:32:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45847 Received: (qmail 14579 invoked by uid 1010); 19 May 2020 17:32:08 -0000 X-Qmail-Scanner-Diagnostics: from smtpq1.tb.ukmail.iss.as9143.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25814. spamassassin: 3.4.4. Clear:RC:0(212.54.57.96):SA:0(-2.7/5.0):. Processed in 3.792097 secs); 19 May 2020 17:32:08 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _mailcloud.virginmedia.com designates 212.54.57.96 as permitted sender) X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.133 X-CNFS-Analysis: v=2.3 cv=FMeAO9gs c=1 sm=1 tr=0 a=ShKnLeKYHz8gHcl3UCxcnw==:117 a=KEnZaF_ea6UA:10 a=IkcTkHD0fZMA:10 a=DoY9bV0jb9AA:10 a=N898d1J4AAAA:8 a=XLwWogefcs8ahp8xrKkA:9 a=QEXdDO2ut3YA:10 a=4OhKILdWXy8MGewZJRtY:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com Date: Tue, 19 May 2020 18:31:26 +0100 (BST) From: Peter Stephenson To: Zsh hackers list Message-ID: <354439768.604804.1589909487014@mail2.virginmedia.com> In-Reply-To: <20200517090348.2lomdks3fpmxl433@chazelas.org> References: <20200517090348.2lomdks3fpmxl433@chazelas.org> Subject: Re: Opening a file descriptor for reading with exec breaks vim shell MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev69 X-Originating-IP: 165.225.81.56 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4wfIfKmF3U3Ff3kdAx1CnlLpLW4HyJVsxMxmZ6d3MQewmgLTSrESy9MaLglW4/o74U6zQvBl5i7R2uc4U2mOSAf7Jz9+DmOQfYLBNGtVWvdzxJafkqj2Ud 6aLA7RAGqK620jw8vcXnCJNiUGDYKy41P+1Uu2PAtRUMYWE25B/QHhzceaQnToRgsGgp1gU0OaKdS0ZLPeYkKiGl60yEw/RX+o8= On 17 May 2020 at 10:03 Stephane Chazelas wrote: > The patch below fixes those, but I have to admit there's a lot > of the related code in zsh I don't understand, a lot of the > behaviour I don't understand either. It's possible that patch > could break things related to clone, zpty, set -m or opening tty > devices, but it seems to me that some of that is already quite > broken. Should really follow up to this... Actually, I don't think set -m was ever mended; I think it's always been a bit of an afterthought that sets up a process group, but doesn't do a lot else. I'd be inclined not to worry about side effects of this patch unless there's something demonstrably worse, since it's fixing something you would expect to work (and that doesn't depend on zsh wizardry). pws