From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38675-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 23996 invoked by alias); 13 Jun 2016 22:06:18 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38675
Received: (qmail 9361 invoked from network); 13 Jun 2016 22:06:16 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1465855246; bh=fluaS73MI/NcOcaScINd68W/EMx3abYtfzIfDcOLupQ=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=W5kmFbJ+JFbVF5H63PLp9dGv3OHafGr2Rrw9JUfznzcDcwssYRkzubxa2hk3ng+q6bGeAv6bLAZBSePlq/NiCwjikXsd751KcGiIZgZyOlP3F0tx6ECddMIYjexedAHJmtXJOKcsYWjqoaMDv/GkPlyYwfWSYjF5CKjjP32QTZPrdtzggTza74xIjcAxUq0u3tYoFUmxhhmvSw0VfVYgyLfo1flluxq5xWHJB6bcrpU0cltJr2mN9TZHdFnlqSEZGGVHaN+N1SoHlsx1idGdt9ZzgMY9zjnRv2z4Ux2W7pmTkyNv0hWRcmIi1wo0Wk63YZ3q/TSQmO2KWMGLPDqxDw==
X-Yahoo-Newman-Id: 602496.79264.bm@smtp147.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: pEoMqawVM1maygZB1ZVc.kfuW1MlOj6z_vrAVxN8djgBDSA
 8gMRU7ckst2o5rZ8kbcOUnYSWZTRuUSplrL5R8tdu5_9PewMOPziZl1XWOtc
 QwBxGd4WDNXfbO7p0GapNQomLS6bMNdo5EmDB6OPDrNdum7iBlUE04ELm7Ou
 G87N0X_iRSP3nTeFcXC4pHujUrD7lwEIjLk2oBngjDaU5VdMrdxvpM9h.rty
 JqdcP9uWmxca_XZJD17VsYuanawXajyLSqnixvI8hrOebuZZd__xKS6M7wZy
 kkFBR_b2xscIIVhMLXS.qQcj5sotNus7Da2IlI7nnK6tY2YJDMtLeIviZ9eG
 9RqgvXY1UHrJ_0m11nY9_X38RoY6iR0.iKm3cK96dJ_gFQpftVObKVM5K5Gb
 p79iiqqYvNI6qXq_O39zN3i1vxASMzn2wRWw3sU4uMOoHxTmIhCelKX6CQZQ
 NWHxMkRXhOLtIuWJ3qY_vYn3VVz9KF0onDrosfW6JLLJO_3cPx7UTX5_tYP_
 s9DxOx3oLLbzpSGWwoSyw4NKJtkJ9cw--
X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI-
In-reply-to: <160612174712.ZM10957@torch.brasslantern.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <87oa76172f.fsf@secretsauce.net> <160612174712.ZM10957@torch.brasslantern.com>
To: Dima Kogan <dima@secretsauce.net>, zsh-workers <zsh-workers@zsh.org>
Subject: Re: Regression: broken completion on modification time
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3668.1465855225.1@thecus.kiddle.eu>
Date: Tue, 14 Jun 2016 00:00:45 +0200
Message-ID: <3670.1465855245@thecus.kiddle.eu>

Bart wrote:
> There was some controversy about this when it was added and discussion
> of how to keep it from kicking in if menu selection was NOT enabled,
> but I guess it never got fully resolved.

It should probably at least bail out if the complist module isn't loaded as
per this patch. Or have you got any better ideas on what to check for?

> In the meantime, to mostly get your old behavior back:
>
>     zstyle ':completion:*:dates' max-matches-length 0

You might also want to try enabling menu selection. At a minimum, that
would be:
  zmodload zsh/complist
  zstyle ':completion*:default' menu 'select=0'

Oliver

diff --git a/Completion/Unix/Type/_dates b/Completion/Unix/Type/_dates
index 83397b4..549bab2 100644
--- a/Completion/Unix/Type/_dates
+++ b/Completion/Unix/Type/_dates
@@ -9,7 +9,7 @@
 #   max-matches-length : maximum number or percentage of lines to use for
 #                        completion listing, if both are specified, the
 #                        lowest takes precedence.
-#   format             : override date format
+#   date-format        : override date format
 
 local -a disp cand expl
 local userformat format spacer=1 spacing month monstart skip match
@@ -37,6 +37,7 @@ _tags dates || return 0
 _comp_mesg=yes
 _description -2V -x dates expl date
 compadd "${@:/-X/-x}" "$expl[@]" -
+zmodload -e zsh/complist || return 0
 [[ -n $PREFIX$SUFFIX ]] && return 0
 (( rows )) || return 0
 compstate[list]='packed rows'