From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: (qmail 17817 invoked from network); 12 Mar 2020 19:14:05 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from unknown (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTP; 12 Mar 2020 19:14:05 -0000 Received: (qmail 6887 invoked by alias); 12 Mar 2020 19:13:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45548 Received: (qmail 18491 invoked by uid 1010); 12 Mar 2020 19:13:58 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt1-f196.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25744. spamassassin: 3.4.2. Clear:RC:0(209.85.160.196):SA:0(-1.9/5.0):. Processed in 2.258196 secs); 12 Mar 2020 19:13:58 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.160.196 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cvUvNrEuq10q8MygQJjpmdwhF+/jLvD5aMonVBOtmHw=; b=tLrz7N44odGo7zn1CuDVSC1lBu7CxG8Bu8TYKIBSIPbr2GAOdNiI2WnV1XlssXbRnv s4F7AOTZiFdBanpqyxFzq9NWK8nGWTtMAuFAtCuWT3K1nNX4RUymZf+p3mTRUn9ABEf2 MopyMU9olgWjDyy+P1Vuld5EYE7RkokGQtNxEjvcLYnqEni4nIAPa4Lh2WZYBaQYq2r+ nr20T/6bYyrr7LTW/x7EiLJPdtB/oKHsEnDc4nP9ml0+HhsJm/x/0D8Y4Bjuxe1K8O9h a5xoihMv0LeNIr1ZIze7emS3xscpkiIoFYlot3QNfImbcUOQCVX2Q1l6k8ZlNYBwpmBh 9obQ== X-Gm-Message-State: ANhLgQ0eDhm6jj77kFGtqhk5uSK8TLv+mRuM0gBkFoCKn5fhgYvUzMkz 06tKigMfv6B/FUMniP0/6O1Jpf5JIIs= X-Google-Smtp-Source: ADFU+vu9P2LjapfvxcIWWKoVAdET4RiySfgMh9dm6jYOklNdFxiVHNScDid646olKvKq7mCSovJjfg== X-Received: by 2002:ac8:65d0:: with SMTP id t16mr8779595qto.154.1584040402785; Thu, 12 Mar 2020 12:13:22 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] Enable sub-second timeout in zsystem flock From: dana In-Reply-To: Date: Thu, 12 Mar 2020 14:13:21 -0500 Cc: "zsh-workers@zsh.org" Content-Transfer-Encoding: quoted-printable Message-Id: <36C08941-07DC-4C00-AC72-0F9CDBE091FC@dana.is> References: <20190729203521.upp5ku3bsr3hsnxq@phare.normalesup.org> <20200104184734.ienw42rwq2xu6aap@phare.normalesup.org> <43775C64-0254-45AB-81AB-B04AE80C4416@dana.is> <20200106173030.eb2pg4rhhgysh35r@phare.normalesup.org> <20200111154143.fjtwgfnztqfmkyda@phare.normalesup.org> <20200308183907.mxnhqrr2uflwooax@phare.normalesup.org> To: Cedric Ware X-Mailer: Apple Mail (2.3445.104.11) On 12 Mar 2020, at 13:46, dana wrote: > 1. All of the `else false`es in these tests seem redundant. If the = condition > doesn't pass it'll return >0 automatically This part is wrong of course :p The other part stands though dana