From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23227 invoked from network); 27 Mar 2021 19:29:31 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 27 Mar 2021 19:29:31 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1616873371; b=tFV8Qt0zKZKHOPzU1KhH6j3OBdAFeVTG1va74pO0tv0ygXarDNp/J8TAjfxwswtGvWNkEoJISD 5soK/KrVRrlQt5sO7LqjpQZZJkEFv9gTeIFjKsyqLdw+NVdAuRkkJy9C7/kexDEvCVegrkpxgN jcLk7AQ/ZaG/5jVYGbq04+k/toZ8UjQWLmvY3IO0nDU+RvKJnIKgqoiS++1QKPoh+Zmqxc8jbD wcOHZQUHxyNwdOexfHWEfEF3wkxRl12dzsJyRf2lJJmia4J+t/Rku8/9WoLl0VM2r/Pon+jZb1 oLwqdlaMzS2xfHcMdbLepq5xWCpiAYqCRtiHUEFWRQQ0lA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=larryv.me header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=pass header.from=larryv.me; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1616873371; bh=daYD/IiNDpHLMYEhEUmuneJW8BOOwpinSNYAdKE0P5w=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To: Message-ID:MIME-Version:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=0Y8Zs1axWvLk9gWl34KnpWrBnWztkjM2KCS4O3hA/Ti3I+9pez5ri/sOQnjHesx77XgtQCOjlx i37IZwlxFYjMwLl8rpBUT7zLHLregqg7LrdIxFloZfR3yKp9EbtYCYetRJUdSr/hQbrMOlnEpc I1JCuTsfGVDubDypEXPIOqRypYdUBM32UroDKvvqtGvrl5nllpGpcKsMMSwlRS/cfyWq9tEv/X 06CbQQ9lfl4GmCqbYk5K53ec3YIDm9apOvnZHf2a6KU/PLmaAbF7w81vc6gQvAu83M1cw6ZDWa gPD9QNCwFy6DWWyQQbaesPSc76nQ+A5pOxagUiSl4ORjlA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=4iwpMbPOG+HoGMO1CqzNZ/bDkdqvStilXEvFbdGWYEA=; b=Ev2vQ6g8EKQWxayRBQuQWQ+GDC UPRR7FAU8S7ipaDAOoqF+cV23GQIXfNQXV8BmoRE6TFhVTEIl1FfyP7x0Q44auT2ZB+AprmrrAzdn XMahtBwWr1DD3S3Xcu5YydyghqyU+dUJWiHtO2athVMluUYFTZpaxSWAcSRVdhJna70XPiODistwY lK3akMk+r1+61umh+w0xl6wZHRLN3hqQnxGffpChV1mrEND/7RGEEkczeOaDRFHqIYnuJ6GbYMSQR TjpLQdh2vaL6CZDQIrF3xhZq0Ypt3QQ4m8r2020DzKiTb1i0e2rJbrKhov08tin+MJivThWoSASgM JwMOVxww==; Received: from authenticated user by zero.zsh.org with local id 1lQEcl-0001t9-Fz; Sat, 27 Mar 2021 19:29:31 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=larryv.me header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=pass header.from=larryv.me; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37749) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lQEcX-0001jM-PO; Sat, 27 Mar 2021 19:29:19 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B7F465C0081; Sat, 27 Mar 2021 15:29:16 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute6.internal (MEProxy); Sat, 27 Mar 2021 15:29:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=larryv.me; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=4iwpMbPOG+HoGMO1CqzNZ/bDkdqvSti lXEvFbdGWYEA=; b=aZHFBHa6klsgLjMTZabWPmfVIH1w883PvKZoUu0VaruvTqD 31h/KxYKFQVmEM7yMgzbZ20cfRQaSZGa4Q77Vec+Q/sOSl6jd9Q8/7Fdsn3THEmF lzPgzgxrD7kxE4ZNDiP0ymTcBPCgXqtVTQhqYhsHRQyhmGYzGf4xgYkzXJ7HMZeh mA+ohVw66Q2u3bJMYgM6M5CpU0lleU9ny64pNQFaGIhAmYerXsht1GpqEDj1+PVv npWBx1VfOMZHyPFxuLd9iOH2R3g2/LYgLgWmrgmM1yqZXE3uCy1g9JTRFt7gi4MS 8+TYds/zyU7+nAho9kNAjHzW2Po8Edja7c2Rb4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4iwpMb POG+HoGMO1CqzNZ/bDkdqvStilXEvFbdGWYEA=; b=Tn6/YyeAzXvkBl/QtdTH5A iwUbrazVwFU3qb7Wd+UKvM4pxeYPWJicrd//kgx7+NQ3M5P19et5XDaEe3M4SWCd +JhIOipxPbjxcSA7kLaDvEkhAyRAymjSCspzzYOVdJ6TfVvu7DWNMswsGJT93Et1 OAa9llgKkA/RmpQSB5ToAhEG4TR43MX5p3PflUu3AUr3pYB0HJE+2MGVz0OhJhi0 8U2SYZv63a/T3tZOVkRD9AOy8sEEAXy+DZhjk3bLdLwNDD1qxXklrTGlVOd8nudu jUfXQ8jNSlx1RmMUf/TbDxAMtKjvy7/SHBeK9ba5+v1eP00zjb8RZDjEl/owp3JQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehgedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpefnrgif rhgvnhgtvggpgggvlhojiihquhgviicuoehvqheslhgrrhhrhihvrdhmvgeqnecuggftrf grthhtvghrnhepjeefheejgfefueegfffgfeevtdfgkeekueejvdeugfegleevgfehkefg vdevueeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epvhhqsehlrghrrhihvhdrmhgv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5D7B7A00073; Sat, 27 Mar 2021 15:29:16 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: <36b56560-ba73-496b-b9b4-54d928a23b8f@www.fastmail.com> In-Reply-To: <20210104051448.083bb483@tarpaulin.shahaf.local2> References: <20201231054131.682544-1-felipe.contreras@gmail.com> <20201231054131.682544-2-felipe.contreras@gmail.com> <8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com> <20210104051448.083bb483@tarpaulin.shahaf.local2> Date: Sat, 27 Mar 2021 15:28:56 -0400 From: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= To: "Felipe Contreras" Cc: zsh-workers@zsh.org Subject: Re: [PATCH 1/3] src: fix build warnings Content-Type: text/plain X-Seq: 48265 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Hi, On Mon, Jan 4, 2021, at 12:14 AM, Daniel Shahaf wrote: > Felipe Contreras wrote on Sat, 02 Jan 2021 12:30 -0600: > > The best fix is to allocate one byte, especially if it's going to be > > freed later on. > > Yes, please revise the patch to allocate byte(s) from the heap as > needed. (See comments at the top of mem.c, and, for instance, > dupstring() v. ztrdup().) Any plans to send a revised patch? vq