From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh workers <zsh-workers@sunsite.dk>
Subject: PATCH: minor bug with f glob qualifier
Date: Fri, 01 Aug 2003 13:56:00 +0200 [thread overview]
Message-ID: <3714.1059738960@gmcs3.local> (raw)
An empty spec component for the f glob qualifier could cause an
infinite loop in the code. e.g. ls *(f:,755:)
This patch fixes that by making it print an error instead.
Oliver
Index: Src/glob.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/glob.c,v
retrieving revision 1.29
diff -u -r1.29 glob.c
--- Src/glob.c 20 Feb 2003 08:17:48 -0000 1.29
+++ Src/glob.c 1 Aug 2003 11:49:38 -0000
@@ -814,7 +814,7 @@
}
if (how == '=' || how == '-')
no |= val & mask;
- } else {
+ } else if (!(end && c == end) && c != ',' && c) {
t = 07777;
while ((c = *p) == '?' || c == Quest ||
(c >= '0' && c <= '7')) {
@@ -838,7 +838,10 @@
yes |= val;
else
no |= val;
- }
+ } else {
+ zerr("invalid mode specification", NULL, 0);
+ return 0;
+ }
} while (end && c != end);
*s = p;
reply other threads:[~2003-08-01 15:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3714.1059738960@gmcs3.local \
--to=okiddle@yahoo.co.uk \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).