zsh-workers
 help / color / mirror / code / Atom feed
* PATCH: pws-24: Stop the unbearable beeping of magic-space
@ 1999-06-27  8:42 Bart Schaefer
  1999-06-27 13:25 ` Peter Stephenson
  0 siblings, 1 reply; 4+ messages in thread
From: Bart Schaefer @ 1999-06-27  8:42 UTC (permalink / raw)
  To: zsh-workers

I should have noticed this when 6814 was posted, but I was preoccupied with
testing job control in 3.0.6 ...

If you have

	bindkey " " magic-space

then every time you press the spacebar you get a beep, unless there happens
to be an expandable history item in the word.

Now, the really good thing would be for doexpandhist() to return failure
only if there is a history reference but it can't be expanded, rather than
failing whenever no expansion took place.  It's beyond my comprehension of
the interaction between zle and the history mechanism to pull that off, so
I settled for making magic-space fail only if selfinsert() does [the old
code didn't make sense anyway -- why store the return from selfinsert and
then do nothing with it?].

Line numbers below may be off a bit, because I also got annoyed by Oliver
Kiddle's patch from 6772.  Gosh, I actually went one whole revision of zsh
without having to either put in or maintain a local change ...

Index: Src/Zle/zle_tricky.c
@@ -8249,8 +8243,9 @@
 {
     int ret;
     c = ' ';
-    ret = selfinsert(args);
-    return !doexpandhist();
+    if (!(ret = selfinsert(args)))
+	doexpandhist();
+    return ret;
 }
 
 /**/

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~1999-06-28  9:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-06-27  8:42 PATCH: pws-24: Stop the unbearable beeping of magic-space Bart Schaefer
1999-06-27 13:25 ` Peter Stephenson
1999-06-27 16:32   ` Bart Schaefer
1999-06-28  9:03   ` job completion (was Re: PATCH: pws-24: Stop the unbearable beeping of magic-space) Oliver Kiddle

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).