From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11998 invoked by alias); 3 Nov 2016 12:50:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39817 Received: (qmail 22427 invoked from network); 3 Nov 2016 12:50:29 -0000 X-Qmail-Scanner-Diagnostics: from nm20-vm3.bullet.mail.ir2.yahoo.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(212.82.96.245):SA:0(0.0/5.0):. Processed in 0.361647 secs); 03 Nov 2016 12:50:29 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: okiddle@yahoo.co.uk X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.mail.yahoo.com designates 212.82.96.245 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1478176982; bh=smmL7eajFS+Qo9JtOwKYtaKSjIAEpbfBoRQi+wDuw9M=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=rfKn0pAzN4vMLnhAvE21HFm9iJypwUEIkOAvQW8LcNkAL2Tsra4uAw7MvfU3T38jfpm5/JacY3yNP+4fZuTlZY/WBzB4wAxozajxW94DIQCDjbPUHR8t0yyhrTY365YCC+wpI8eNDQRR7tJ8z2GNTKyDrnrtlHsYdnkKd5cAsXMy2043UZfjZ8JfnOhCxJc9sTMI4AQjyKCGmisk3XTXtPl/kLHlK78ApgQku4k3cX1F2enWypP/jOJo9z5mDA+jnVaA1jercc4Ja3lCaMJJSXx4C/68rAq575ldkZ9kOxy9JC78j02ZSzEAYZvfnfdq3Ue2FMVn1NfvDrDSTmPlEw== X-Yahoo-Newman-Id: 130906.96315.bm@smtp121.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: G7mvxd0VM1mdBIM79BZLr17CMC0EJHQslXR5FO8ULITngkA GAqCjg.3nmfxTyVYYOGsfk2EhA0a1zoN1cPUR2Wb8fxZRJqzIrKYJkL5nIhd aSI9d9od2skw5WBB97I9GJb_iYbDpMzABzEfdiXFalPdfzJQV32b3P26keM8 jFkIHrfckGTjrM1b2HrjQcoJdmpuLTBn.IQj1kc1DitDkPUADqVYaSkk3IUd q1kl1AFdiB4izBt9nyA0AccYzfnrCc6rm0wG.e1CFJne_0QwzmUs8OgpZJ84 F6PpMLvKkx8QT46T1efd2bjp2GVy.9Gk0rF4SN3CawtFWldFe4H4EIXwoKfC cxmH2P6dlaVyI0OM9gaGnsLFMTbsjUFB5HLTrmkDYMhLMwQUZ8NqfKVN80Pi rtzqolVDrauGSESw9uKHrSCtlrCINtMmV64adR0bOGcgWdLnNbRMTBbQ0ynV lwZXz_JM61db0mFzCeYRtXSo0ul7mDz.6ynxM55rYltFyGCQhcGgXQdcAR.R zjuWbkwgXTgiXpRiRDS_Yx43ZAIpcrcvkOylxRSAuSzM- X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- In-reply-to: <161102214418.ZM12525@torch.brasslantern.com> From: Oliver Kiddle References: <20161005080921.GB26647@raspi> <161005101938.ZM12590@torch.brasslantern.com> <20161102045925.GA6763@fujitsu.shahaf.local2> <11719.1478105483@hydra.kiddle.eu> <161102214418.ZM12525@torch.brasslantern.com> To: zsh-workers@zsh.org Subject: Re: Bug in ZSH's vi emulation MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <37863.1478176981.1@hydra.kiddle.eu> Date: Thu, 03 Nov 2016 13:43:01 +0100 Message-ID: <37864.1478176981@hydra.kiddle.eu> Bart wrote: > So, given 39813, this seems to work: That, along with 39813, looks good. As a further tweak, I had to make keybuflen not be declared static. It might also be good to tweak the comment leading up to this function (startvichange) to reference keybuf instead of lastchar. > All X02zlevi tests pass, and I'm even able to do e.g. gUfx to uppercase > everything through the next "x". Works well in my testing too. We should add a new testcase too such as that below. Oliver diff --git a/Test/X02zlevi.ztst b/Test/X02zlevi.ztst index ced7030..aa3587e 100644 --- a/Test/X02zlevi.ztst +++ b/Test/X02zlevi.ztst @@ -244,6 +244,12 @@ >BUFFER: binging >CURSOR: 3 +# for vi compatibility, this should repeat the previous change + zletest $'worm\erdhd..' +0:use of vi-repeat as the motion and repeat after a failed change +>BUFFER: word +>CURSOR: 2 + zpty_run 'bindkey "^_" undo' zletest $'undoc\037e' 0:use of undo in vi insert mode