From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 80f70781 for ; Thu, 6 Feb 2020 19:33:49 +0000 (UTC) Received: (qmail 19719 invoked by alias); 6 Feb 2020 19:33:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45389 Received: (qmail 5153 invoked by uid 1010); 6 Feb 2020 19:33:40 -0000 X-Qmail-Scanner-Diagnostics: from mail-yb1-f194.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25713. spamassassin: 3.4.2. Clear:RC:0(209.85.219.194):SA:0(-1.9/5.0):. Processed in 3.8718 secs); 06 Feb 2020 19:33:40 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.219.194 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fauRNZMWRb7xGiyuGkg0g9pjh+LNiHy/IW9CdzypZXo=; b=R6GJQcVsmL6THIhJn5raFPoxpD3u4ZyCW0d2IMj0YV+VVx83k65DW4FWV/xvoB2f3D 7re5ZrpaW/hE9NbdZQAqNeBwycis/PLC1dO2uIN05omLUQli7GDxd0I6Lev19ER+z3dU FAxIRnQUzg64USsaYxGFkkvjGG69PDLJjA4ojvatA3mOR11D6/9F7zd0mkVWbEAYJPDo dh/VT0kbkyYYkWplOhSoULGso9UarzX8dbU27rxOHXAXRoKVDKBo41R6/UBQQiAxJUe7 syX9EbNXIyWD+muzyMcMJrHQB4GhgjqwjSyTS5sgurseXIZBPNPL8Fdf9EzX/V7ry98n L/BA== X-Gm-Message-State: APjAAAUi9+3acj/1sDT59YPUZ0HHbFRaWYmZc1a0yGoEehgqaIVjMlks j7swMLUPdj1Unv7xuiOnSbpatwXtx4kbbQ== X-Google-Smtp-Source: APXvYqzC4FXmsUgk3NgVpxrlz8a7NXEIvmryn5QG88W1nx8kwOyqQF1xje/C4VSwmAeUa7saN+nWDQ== X-Received: by 2002:a25:5208:: with SMTP id g8mr4436553ybb.482.1581017579802; Thu, 06 Feb 2020 11:32:59 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] _diff_options doesn't support -w/--ignore-all-space for GNU diff From: dana In-Reply-To: <2525ceed25f15f4ef4984593df64bb1f@iserv.iserv.eu> Date: Thu, 6 Feb 2020 13:32:58 -0600 Cc: Zsh hackers list Content-Transfer-Encoding: quoted-printable Message-Id: <378DCC49-0B9C-4A75-8F86-3D19D6D3A9C2@dana.is> References: <2525ceed25f15f4ef4984593df64bb1f@iserv.iserv.eu> To: Martin von Wittich X-Mailer: Apple Mail (2.3445.104.11) On 6 Feb 2020, at 10:05, Martin von Wittich = wrote: > I'm using GNU diff 3.7 and zsh 5.7.1 as provided by Debian 10.2, and I > noticed that zsh's completion doesn't support diffs = -w/--ignore-all-space > parameter. It looks like this was lost when support for the new FreeBSD diff was = added in workers/43351. I've restored that option (for both GNU and FreeBSD), = thanks. There are still some issues with this function, though. For one thing, = the new FreeBSD diff is heavily based on (almost but not quite identical to) OpenBSD's, so we should probably add OpenBSD into the existing = GNU/FreeBSD mix. I think there are also some option-name inconsistencies between GNU = and the BSDs, but i didn't look super hard. My free time is pretty tied up = in getting 5.8 out right now, but maybe i'll look into this again, some = day, if nobody else does. dana