zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Felix Rosencrantz <f_rosencrantz@yahoo.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: zsh 4.2.0 dumping core on completion attempt
Date: Fri, 28 May 2004 11:37:30 +0200	[thread overview]
Message-ID: <3888.1085737050@trentino.logica.co.uk> (raw)
In-Reply-To: <20040528054001.36732.qmail@web51109.mail.yahoo.com>

[ removed zsh-users ]

Felix Rosencrantz wrote:
> had no problem.  Cygwin gave me this error:
> alternative:69: command not found: _suffix_alias_files

Looks like either _suffix_alias_files is missing or the upgrade from an
older zsh is only partial.

> I was able to reproduce the problem on a rh box within gdb and got this stack
> trace. (Note: _f worked fine for me, this is stack trace for completing "_x")
> #0  strncmp (s1=0x402cbbe4 "xmmap", s2=0x0, n=1)
>     at ../sysdeps/generic/strncmp.c:65
> #1  0x40246179 in cmp_anchors (o=0x402be3e8, n=0x402bc618, join=1)
>     at compmatch.c:1393

It probably just needs:
	 (!o->word || !strncmp(o->word, n->word, o->wlen))) ||
changing to:
         (!o->word || !n->word || !strncmp(o->word, n->word, o->wlen))) ||

We've got o->word == "xmmap", n->word == NULL and o->wlen == n->wlen.
So it might be a bug elsewhere that allows n->word == NULL or it might
be an omission that it isn't checked. Presumably n->wlen == 0 but is
that a length or an initial value?

Could you perhaps have a more detailed look from the debugger. At least
see what n->wlen is and ideally trace back to where o->word, n->word and
n->wlen are set (or not set).  Does that change result in it completing
the right thing?

Unfortunately, I can't reproduce the problem on any system I have access
to. If we can't find a bug higher in the chain, this would at least
avoid it crashing but I'd obviously prefer to understand what's going on.

Oliver


  reply	other threads:[~2004-05-28  9:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3m5afmj8tzpu$.dlg@thorstenkampe.de>
     [not found] ` <20040525063239.19784.qmail@web51107.mail.yahoo.com>
2004-05-25 22:53   ` Thorsten Kampe
2004-05-25 23:46     ` Danek Duvall
2004-05-26 10:55       ` Peter Stephenson
2004-05-26 14:17         ` Danek Duvall
2004-05-28  5:40     ` Felix Rosencrantz
2004-05-28  9:37       ` Oliver Kiddle [this message]
2004-05-28  9:43         ` Oliver Kiddle
2004-05-28 10:01           ` Peter Stephenson
2004-06-01  7:16         ` Felix Rosencrantz
2004-06-02  7:58           ` Felix Rosencrantz
2004-06-02  9:29             ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3888.1085737050@trentino.logica.co.uk \
    --to=okiddle@yahoo.co.uk \
    --cc=f_rosencrantz@yahoo.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).