zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <opk@zsh.org>
To: Eric Cook <llua@gmx.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] remote files completion: remove double-escaping
Date: Mon, 15 Jul 2024 01:22:14 +0200	[thread overview]
Message-ID: <39311-1720999334.884784@cVR2.ekVN.d3n2> (raw)
In-Reply-To: <b401a0f1-290c-4030-a90a-e6805182455d@gmx.com>

Eric Cook wrote:
> On 7/8/24 5:17 PM, Lawrence Velázquez wrote:
> >> On May 28, 2024, at 11:40 AM, Lyn Fugmann <me@fugi.dev> wrote:
> >>
> >> I finally got around to testing this. The behavior appears to depend only on the local version of rsync, not on the remote version. Tested using local rsync 3.2.3 and 3.2.7, remote rsync 3.1.3 and 3.2.7. So I think the patch should be fine as is. (I would expect very few people to run an over two years old version of rsync and a recent version of zsh on the same local machine.)
> >
> > A GitHub user is inquiring about the status of this contribution.
> >
> > https://github.com/zsh-users/zsh/pull/114#issuecomment-2212591419
> >
> a possible fix, open to a better option letter for _remote_files than -Q, since compadd has -Q.

-Q with compadd's meaning is unlikely to be useful with _remote_files so
overloading it should be harmless enough.

-O is the scp option to use the old protocol. Given that option, scp
completion would ideally fallback to the old behaviour.

Oliver


  reply	other threads:[~2024-07-14 23:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 10:46 Lyn Fugmann
2024-04-10 18:45 ` Mikael Magnusson
2024-04-12 18:59   ` Bart Schaefer
2024-05-28 15:40     ` Lyn Fugmann
2024-07-08 21:17       ` Lawrence Velázquez
2024-07-14 16:37         ` Eric Cook
2024-07-14 23:22           ` Oliver Kiddle [this message]
2024-08-04  0:10             ` Eric Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39311-1720999334.884784@cVR2.ekVN.d3n2 \
    --to=opk@zsh.org \
    --cc=llua@gmx.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).