From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: dana <dana@dana.is>, Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: completion match ordering
Date: Tue, 07 May 2019 14:39:20 +0200 [thread overview]
Message-ID: <3977-1557232760.220491@D46d.Nn2D.jsvI> (raw)
In-Reply-To: <693EF72F-D53C-429F-9B0C-C44BB19AB1DB@dana.is>
You wrote:
> Your matchcmp() update removes SORTIT_IGNORING_BACKSLASHES entirely ??? is that
> deliberate in light of my changes? It should always make sense to skip
No, not deliberate.
I picked up my old git branch for this change and hadn't really tested
together. I didn't think the patch would even apply cleanly. I'll add in
the missing bitwise OR against SORTIT_IGNORING_BACKSLASHES in the call
to zstrcmp() in matchcmp(), when committing the rest of it.
> back-slashes in completion matches unless `compadd -Q` is used to bypass
> escaping, shouldn't it? Or do i misunderstand?
That makes sense as you describe it.
Oliver
next prev parent reply other threads:[~2019-05-07 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 0:13 [PATCH] Completion: Sort lz4 compression levels properly (+ a question) dana
2018-11-07 10:35 ` Oliver Kiddle
2018-11-07 17:52 ` dana
2018-11-26 1:25 ` completion match ordering Oliver Kiddle
2018-11-26 3:09 ` Daniel Shahaf
2018-11-26 5:18 ` dana
2018-11-26 9:37 ` Peter Stephenson
2018-11-26 23:07 ` dana
2019-05-06 21:16 ` PATCH: " Oliver Kiddle
2019-05-07 0:10 ` dana
2019-05-07 12:39 ` Oliver Kiddle [this message]
2019-08-22 8:39 ` Daniel Hahler
2019-08-23 19:05 ` Oliver Kiddle
2019-08-25 14:25 ` Daniel Hahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3977-1557232760.220491@D46d.Nn2D.jsvI \
--to=okiddle@yahoo.co.uk \
--cc=dana@dana.is \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).