From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15973 invoked from network); 8 May 2001 11:45:25 -0000 Received: from sunsite.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 8 May 2001 11:45:25 -0000 Received: (qmail 20949 invoked by alias); 8 May 2001 11:45:12 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 14255 Received: (qmail 20931 invoked from network); 8 May 2001 11:45:10 -0000 Sender: kiddleo Message-ID: <3AF7DC40.9076728F@u.genie.co.uk> Date: Tue, 08 May 2001 12:45:04 +0100 From: Oliver Kiddle X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.15 i686) X-Accept-Language: en MIME-Version: 1.0 To: zsh-workers@sunsite.dk Subject: Re: problem with _arguments exclusion lists References: <200105071110.NAA02851@beta.informatik.hu-berlin.de> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sven Wischnowsky wrote:  > > partially: _vnc can be fixed by using the pattern (|:[0-9]#) which I'll > > commit later if _guard stays as it is. I'll commit this now. > > Well, _guard was just an attempt at helping in what I consider the usual > completion style in most cases (i.e. what most people would expect or > like to see in most cases). As I said, we could always add an option to > _guard to specify other behaviour (for the return value or pattern > matching or whatnot). Feel free to add one if you like. Well it is really the _arguments handling of a 0 return code and not _guard which I believe could be bettered. That is, it should complete possible options (like the -c3nf example) as well as displaying `number'. I'm happy to require _guard patterns to need to match their thing partially, hence the commit on the _vnc change. I agree though that _guard's style of pattern matching can always be extended with an option later if the need arises. Oliver Index: Completion/X/Command/_vnc =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/X/Command/_vnc,v retrieving revision 1.1 diff -u -r1.1 _vnc --- Completion/X/Command/_vnc 2001/04/26 14:00:45 1.1 +++ Completion/X/Command/_vnc 2001/05/08 11:43:40 @@ -13,7 +13,7 @@ '-geometry:geometry:(1600x1200 1280x1024 1152x864 1024x768 800x600 640x480)' \ '-depth:pixel depth:(8 16 24 32)' \ '-pixelformat:pixel format' \ - '1::display number:_guard ":[0-9]#"' \ + '1::display number:_guard "(|:[0-9]#)"' \ - kill \ "-kill:display number:($displays)" \ - help \