From: Oliver Kiddle <opk@u.genie.co.uk>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: Nasty bug in array-element typeset assignments
Date: Thu, 26 Jul 2001 12:38:20 +0100 [thread overview]
Message-ID: <3B60012C.EF6E906A@u.genie.co.uk> (raw)
In-Reply-To: <002001c115c3$524f76b0$21c9ca95@mow.siemens.ru>
Borsenkow Andrej wrote:
>
> Commit log does not have article number, but diffs are here:
Going by the commit date, I can't find an associated message in the
archives.
> > Really? So what would it do? Make the whole foo array local or just the
> > first element? Clearly neither works.
>
> Probably, intent was to create new local array.
Urgh. Is that really that useful? I think it'd be better to save the
extra mess in the code and disallow it with roughly what you get by
adding this:
} else if (on & PM_LOCAL && locallevel) {
zerrnam(cname,
"%s, can't create local array elements", pname, 0);
return NULL;
after the similar bit for readonly inside the strchr(pname, '[') test in
typeset_single.
Also, if this is fixed to make the whole array local but the fix is
complicated then this small change might be a good option for the 4.0
branch.
Incidentally, I get a couple of test failures with the latest CVS - on
with _arguments and the other for posixbuiltins.
Oliver
next prev parent reply other threads:[~2001-07-26 11:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-26 5:13 Bart Schaefer
2001-07-26 9:23 ` Peter Stephenson
2001-07-26 9:28 ` Borsenkow Andrej
2001-07-26 9:44 ` Peter Stephenson
2001-07-26 9:57 ` Borsenkow Andrej
2001-07-26 10:04 ` Oliver Kiddle
2001-07-26 11:07 ` Oliver Kiddle
2001-07-26 11:08 ` Borsenkow Andrej
2001-07-26 11:18 ` Borsenkow Andrej
2001-07-26 11:38 ` Oliver Kiddle [this message]
2001-07-26 11:45 ` Peter Stephenson
2001-07-26 12:21 ` PATCH: posixbuiltins test (was Re: Nasty bug in array-element typeset assignments) Oliver Kiddle
2001-07-26 13:24 ` Nasty bug in array-element typeset assignments Borsenkow Andrej
2001-07-26 17:49 ` Bart Schaefer
2001-08-12 18:55 ` PATCH (?): " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B60012C.EF6E906A@u.genie.co.uk \
--to=opk@u.genie.co.uk \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).