From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15661 invoked by alias); 13 Aug 2018 14:19:48 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43286 Received: (qmail 16439 invoked by uid 1010); 13 Aug 2018 14:19:47 -0000 X-Qmail-Scanner-Diagnostics: from mail-io0-f181.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.223.181):SA:0(-1.9/5.0):. Processed in 2.102376 secs); 13 Aug 2018 14:19:47 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_PASS,T_DKIMWL_WL_MED,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=T/0z3J1nbaTGEkYY5nKMccqUb3ATZXwj5fcHyba6a8E=; b=qlWoBwyU6xs7o2gqgj8qIL8UQgxNh+g9Y1UKjhiH3NlkgqyvNorwG8wg2LVaZ7Fdma SMg3BdEWWYrl7fDu3ueiDbo2pFJ83eO7u0TyfMHHLj1LAzRWDZ9qiU6l1g1t4NOGGlxt awi2za3GXXtRpekky56iGqWTq9FEeAEnyLx5Tc8Rsu4RqSYijM2x/zNZaPS21eB2VpOV Ec+Cbr35VgjMSun6pvwJe5v1vnQ6nXslrqELlBW6oUnV0YE+4U4v5dgqBg2fmHuTGoFC L3qgGqR8t7tCAcM9S5ohtJ9/UFnRK4FTMQPb+IIVkBdh3q32yvZtGHGXbPxF2rOKejMu 6+ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=T/0z3J1nbaTGEkYY5nKMccqUb3ATZXwj5fcHyba6a8E=; b=b4RjyyXeHcZ5Z7RTlAh5cJ04+o8Jv1DlDgOgRoBl60HfagbrdIVf3CInoM6t1Q0PEe DGWhXeg/sAhm1XJeXh4no4zVFgQNGbjTGpE3ciWSRFkxzxjaka0qjELVmW1D5UFUZBAS OP+VVpa8Q8Shl57b3CG5lhwgtWTNIc6etNpG5MWMYVW3uv7EVB67BJygHdgTDro4Ok8Z BPTzVV0IWLqdvwX/2cJSCzX0xFNGpDri9AaKk9qHNPX4srZwmtoXffF4V/EQ/S/zpgMt +ClA+s5L5/w/z2M/K5Y+77waw5W15lvKwzTJw78MO4HkhEeT3rm/UHaLM+ZKas9AWlgC uNNQ== X-Gm-Message-State: AOUpUlHo8Ff6gg1ZvNP+9hCG3xEzVlKLpfKWHvD3EFq6G8YS7iKMvs6b vbN76XT8HRKnrf8p0lX76nYlVg== X-Google-Smtp-Source: AA+uWPyAGL0O/dHlHqdtjmVCU+W2/Fn2Iuy0ZNf87kbHR3Xbz2gtQPU8yfSS1atHzAQUhz1LtHuaWg== X-Received: by 2002:a5e:c90e:: with SMTP id z14-v6mr15432899iol.268.1534169983139; Mon, 13 Aug 2018 07:19:43 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: "off by one fix in multiple prompts" breaks multiline prompt From: dana In-Reply-To: <20180813125810eucas1p181a58cb55dc815863d6d81e1cd629d71~KcwV9B7ZD1627716277eucas1p1o@eucas1p1.samsung.com> Date: Mon, 13 Aug 2018 09:19:41 -0500 Cc: Guillaume Chazarain , zsh-workers@zsh.org, warepire.ml@gmail.com Content-Transfer-Encoding: quoted-printable Message-Id: <3F00E10A-6A65-4201-A4E2-2A29929111C1@dana.is> References: <20180813084255eucas1p102bc21872ad72a2cd049d8d9db2f0e86~KZResIryo0309103091eucas1p10@eucas1p1.samsung.com> <20180813113640eucas1p19d52c9c05089626f375a00c5115aef32~KbpML4Mzp0510505105eucas1p1P@eucas1p1.samsung.com> <20180813125810eucas1p181a58cb55dc815863d6d81e1cd629d71~KcwV9B7ZD1627716277eucas1p1o@eucas1p1.samsung.com> To: Peter Stephenson X-Mailer: Apple Mail (2.3445.8.2) On 13 Aug 2018, at 07:58, Peter Stephenson = wrote: >I suspect dana was saying we need something like this? Has this got >anything to do with it? (Second guessing other people's fixes is = really >hard work...) Yeah, i probably should have tested the patch that was actually = submitted, sorry. We were kind of working on it in parallel after Wapire suggested = on IRC that that might be a fix to their problem. The additional change you mentioned addresses the difference between the = patch as submitted and what i was testing. However, i just tried it and it = does not fix this issue (where the last 'hard' line of the prompt wraps). Looking at that function again, i wonder if the original problem was = actually related to the fact that it compares the current column count (and potentially increments the height) before checking whether the current = character is a new-line? That would explain why it was producing an extra cup when = it encountered a line that was exactly as wide as the screen. dana