zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: completion match ordering
Date: Sun, 25 Nov 2018 23:18:13 -0600	[thread overview]
Message-ID: <3F314B28-968A-4C50-BDCB-162A53FB3AC3@dana.is> (raw)
In-Reply-To: <1543201779.3048772.1588561784.55C4BFED@webmail.messagingengine.com>

On 25 Nov 2018, at 21:09, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>In general, I would default to assuming we should worry about
>compatibility, unless there's a specific reason not to.  (As a user,
>I assume that my zsh code is forward compatible with new zsh releases
>unless something is specifically documented to be an exception.)

Just in case you missed the background, Oliver found that -o was added
specifically to be used in _list_files, and i couldn't find anywhere else in the
main repo nor in the zsh-completions one that uses it. It is documented, though,
so i guess that's bothersome.

On 25 Nov 2018, at 21:09, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>No, what they *should* be doing is passing arguments transparently,
>without parsing and reserializing them, so when we add "-$letter"
>options to compadd we can do so by changing just one place (namely, the
>C struct declaring the builtin).  Probably by putting the compadd
>options in an array and passing its name, or by putting them in ${argv}
>after ${argv[(i)--]}, etc..

I like the idea of putting them in an array, that would alleviate some anxiety
i've had about this very issue. compadd has so many options, it becomes really
irritating to work around them in helper functions.

On 25 Nov 2018, at 19:25, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
>The patch below is an initial experiment for what I was suggesting.

I haven't really looked at this yet but i will soon. Thank you for working on
it!

dana


  reply	other threads:[~2018-11-26  5:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-04  0:13 [PATCH] Completion: Sort lz4 compression levels properly (+ a question) dana
2018-11-07 10:35 ` Oliver Kiddle
2018-11-07 17:52   ` dana
2018-11-26  1:25   ` completion match ordering Oliver Kiddle
2018-11-26  3:09     ` Daniel Shahaf
2018-11-26  5:18       ` dana [this message]
2018-11-26  9:37     ` Peter Stephenson
2018-11-26 23:07     ` dana
2019-05-06 21:16     ` PATCH: " Oliver Kiddle
2019-05-07  0:10       ` dana
2019-05-07 12:39         ` Oliver Kiddle
2019-08-22  8:39       ` Daniel Hahler
2019-08-23 19:05         ` Oliver Kiddle
2019-08-25 14:25           ` Daniel Hahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F314B28-968A-4C50-BDCB-162A53FB3AC3@dana.is \
    --to=dana@dana.is \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).