From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 4607737e for ; Mon, 26 Nov 2018 05:18:36 +0000 (UTC) Received: (qmail 18748 invoked by alias); 26 Nov 2018 05:18:22 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43844 Received: (qmail 1856 invoked by uid 1010); 26 Nov 2018 05:18:22 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f173.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.166.173):SA:0(-1.9/5.0):. Processed in 3.948377 secs); 26 Nov 2018 05:18:22 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=V9UaDQzGr43rWmK7V3P4Fjd8/+Z/m0Fja/onK8zUd0I=; b=BWO5SeYbHLj4yj++ZY38g5diuVEvuQYXQ9pjhyUWYuTG85hhK21/tINmaPjmbY6nTK d/ukAWeQPZV9g2TKqnAnIkdcolQbi6Aexh36hCqFAIpljgKBVQw2/gQ0UL5nU9HZ9A+7 mAoueVi1hI9KfIWlKObrCX7/uolZF1+wzcpOBei7dgxmABKb6PwR6MXq0jMKDRI2w7hQ EYPR9shnN+OeHzZaa0XLZvmAknXVtEuF9Zw6zY3syp8GxU+6mS+bSqFykop6a7tLnC6c UWk++hRN375BZMf2t4CnSnBlE6VRzhd81Yp9dj3SCsJ3EgaZ2Htsorj6w7p5H8L+p/5n YJtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=V9UaDQzGr43rWmK7V3P4Fjd8/+Z/m0Fja/onK8zUd0I=; b=ujE1hJSoSaNrLPEowo11AoezWyzqCp89gyZUkO0YLmp3wE7/2z88T4/OElXzSipoD9 2oiqiN5vqi6/bVkGauy3Gpm9RrDpTGOla4lPRBh7SEGYck8Q+ORNnrBpVosbbWm2Q3xM g1Ne4Y8jJMXZSt/ALR0k+E75OzbTejXxsP0vIG3PO+cCKySRScw0cEsMlbbkwjhoe4zz NOHfrnSPxm5FbDseK0Sl88CdClsW7G37ThlBHQGqp73Mn18yNAKajHH5f9XRBNESHccu uCmhzMBGrXbJ5tEeCajlRTQvrsZXz7K4bzrTHOjMuoDTLDLhnZxRWRG5PjIiUsxOqDn2 CPDg== X-Gm-Message-State: AGRZ1gK/JuXR2kQdWDffea7Bsx7eFN8Rbp3ptn9Tq+9DkU5Q2Lf8AAxL JFzJHlMBQ1d6cb0IaGnEnXjTXnrlrO0= X-Google-Smtp-Source: AJdET5fTzFDvd0Jd9HTRNRjZl7lm74YQjkJPAQzhRKdw0Wmc6W98a2Nbft9f/OXvh585bPvES0pMYQ== X-Received: by 2002:a02:3948:: with SMTP id w8mr22200799jae.14.1543209494543; Sun, 25 Nov 2018 21:18:14 -0800 (PST) From: dana Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: completion match ordering Date: Sun, 25 Nov 2018 23:18:13 -0600 References: <75B26F45-E6E6-44BB-80A4-7301CBE480FE@dana.is> <88812-1541586959.338018@YaNA.ZOZt.NKaA> <76839-1543195550.251964@c6AU.RX4q.p78d> <1543201779.3048772.1588561784.55C4BFED@webmail.messagingengine.com> To: Zsh workers In-Reply-To: <1543201779.3048772.1588561784.55C4BFED@webmail.messagingengine.com> Message-Id: <3F314B28-968A-4C50-BDCB-162A53FB3AC3@dana.is> X-Mailer: Apple Mail (2.3445.100.39) On 25 Nov 2018, at 21:09, Daniel Shahaf wrote: >In general, I would default to assuming we should worry about >compatibility, unless there's a specific reason not to. (As a user, >I assume that my zsh code is forward compatible with new zsh releases >unless something is specifically documented to be an exception.) Just in case you missed the background, Oliver found that -o was added specifically to be used in _list_files, and i couldn't find anywhere = else in the main repo nor in the zsh-completions one that uses it. It is documented, = though, so i guess that's bothersome. On 25 Nov 2018, at 21:09, Daniel Shahaf wrote: >No, what they *should* be doing is passing arguments transparently, >without parsing and reserializing them, so when we add "-$letter" >options to compadd we can do so by changing just one place (namely, the >C struct declaring the builtin). Probably by putting the compadd >options in an array and passing its name, or by putting them in ${argv} >after ${argv[(i)--]}, etc.. I like the idea of putting them in an array, that would alleviate some = anxiety i've had about this very issue. compadd has so many options, it becomes = really irritating to work around them in helper functions. On 25 Nov 2018, at 19:25, Oliver Kiddle wrote: >The patch below is an initial experiment for what I was suggesting. I haven't really looked at this yet but i will soon. Thank you for = working on it! dana