From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 909 invoked from network); 10 Dec 2023 23:31:20 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 10 Dec 2023 23:31:20 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1702251081; b=azSo4VJSTUQ8I9ZMYTF0hav5927Q2Odyy1U8oM6B7mejse8mvVqR7aDPPTNzZmSXUTloSr0cyg lM4iquxvRtK9S9KH7TQO8jamPH7UA910O57W2jrBDZpKNcTUCeng0CT1NT5nKFaFa1xDJ4H2/E t8c5SW8YmgQ6KlV3F+WiFYGx7KVadiHTy21dAkBWowLFNOi+3nU3O/SWcnDT386Rbep4NwvBLB 22p/lKK0TjH/rln7qdAgZekuCmZ2UwNNhCce07FqFu4pJnilK+FvUgPMwlLifCYL1eCPpXmpT4 dz4AT+OUkNZ6iryqXVUgZkAPCH4VGbNcxTCP+jrVpVkmLA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-qv1-f45.google.com) smtp.remote-ip=209.85.219.45; dkim=pass header.d=gmail.com header.s=20230601 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1702251081; bh=4JMGXn81HqY2uIYk8EyR+Hm18EDE8GvCtDp7tX38UVc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:DKIM-Signature: DKIM-Signature; b=TgpGFeqKP5uRzeGLGpemYGmMhbZUVT8YM0y1CdxciPxLfGceUIRMBuKLElg4I/8mUdg0LdX/Dk NWfiK0NJa4ZVfbQw3awXyvfP82TgQv4UVu7guQdB1YuVZMsU/62E6X1QSSXvoX2Wn/XvCTNqCJ V3Z08zr6Bpi5bQgk2tFx6k/xrJOMcxJC+VUlwJi/z+QlcQuAcbwpDj4RLxSTcavHn2teNWHKQB xKxDLr09v1OKpBZi75XA3y+vzicMnhaTkyu1kSWZKCv6KamRlkWJ3HOD655StYhhxezfMzIqMk uJT/OHPMpDzu2mO+4qZ2nVhQO0XGWNv2rg9xhSUj2g6YwQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=fMkQDpxS31pOrRAcPfvDTG8eV+zHkIyrzV1KSWS+wvM=; b=DIMqRJooSrIN2AD1VeyBDsZ7X6 5jheQFUw6nlKPNsF3WbhDDf5kZeJS94vmxOq6P+rexveTEuunLOnT/PwToaZEmI7JyEHrYY/KjXBZ oJjIAjoQiu4ydIZz0rXKmtnXhf8alNJUbYGUXj43MM/xPdbEw4OHDRNkEnfwKkEWpvWzdpzbPBWbk ti/3+XJlDS94KmFKUthLAWChQprefGRFQ7PzDH+fPj5O+LkfogINU9eSzaVYL2BFgwxkBAm0fS43k FTa/uwzUSPLGuChAd7by0RL1waBhe3HITY3GnpNBrHtrjjLcZup3B+PYuiJiZota3nq3Obv6hplT7 FlLB2KfA==; Received: by zero.zsh.org with local id 1rCTGa-00093c-EA; Sun, 10 Dec 2023 23:31:20 +0000 Authentication-Results: zsh.org; iprev=pass (mail-qv1-f45.google.com) smtp.remote-ip=209.85.219.45; dkim=pass header.d=gmail.com header.s=20230601 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-qv1-f45.google.com ([209.85.219.45]:48249) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1rCTGM-0008ma-Mt; Sun, 10 Dec 2023 23:31:07 +0000 Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-679dd3055faso25091716d6.0 for ; Sun, 10 Dec 2023 15:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702251065; x=1702855865; darn=zsh.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fMkQDpxS31pOrRAcPfvDTG8eV+zHkIyrzV1KSWS+wvM=; b=RYYv/W/Yzz0JJAYHcF+tMZtdhzaNCdDh7f1b6EPE2EVIUXXutA/EGKVW8wz3HxrDTG rYDdGjbqxt0Exbu1gM55dk7AKzKqH3JBg/tIP7Rah+0h+Ot54TL02yl1tCpNJUyH9lfi e0bnztQPzjY4YxdRMrdAEPj9Cu+jfOPbzlvS37EZLbJA4gJIrk8rVlfOjIbSO7KNGfIu 3S+YmC3va2yDwDXkFr6xUU72T54BbfHIA/9l+f4c9PvtRnqL4gVZsSLEytrJTbKhsifi /LLMcJb6P7c0Mjmp1oSBVODENX0aJvOFCKD+cC6pgM+sDgWBI9glsaEyrMlozVaseWqh E4sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702251065; x=1702855865; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fMkQDpxS31pOrRAcPfvDTG8eV+zHkIyrzV1KSWS+wvM=; b=fDVqC4HcMYImxVQeo8vdoI+Ed4LkARk0x+wuGZLlZwB+wZCwWtbUfPMktRzSEcspxQ bm8WWDdcc4QxNUEWmPoEL3bG8srEFbqw2yZMrNFgWG7Ayh1gbCJSGYBU3rFnB5ToIsBx s5ClhwyYn+MfPiG3DANEov/HQuDqtVPKYUsumRZ1vH2rlwTzrQwOYktA/h5pShsWwCy1 A48Td/xFK9oFgNlyQ+jn4HayfuUOcbkxo6kBYUFADUXf3F5tkYxfWmtYVjbvOYL0TkyW gEsaGiO2y8Jo0YqT2OaFx2k+pdMgmNUr088sf9pYRvtqzvsraS5ebC29CFW8UQ+Hv6hv ZrHQ== X-Gm-Message-State: AOJu0YxvY3hYYyIRi+coPAuIxizoOfldmsdyaa0u5SwSQZ43Z31YiZjw zi1vrB6R/ka69YLMuKQvynbPwx/nMUE= X-Google-Smtp-Source: AGHT+IFXwC2+vebZIkDIxoaie6xKXZerwBqzq43hMOhI6WUholtCS2dkkOJ2JGBTONv7aJtu8Fupew== X-Received: by 2002:a05:6214:141c:b0:67a:a721:9e92 with SMTP id pr28-20020a056214141c00b0067aa7219e92mr4220002qvb.67.1702251065506; Sun, 10 Dec 2023 15:31:05 -0800 (PST) Received: from ?IPV6:2602:47:d950:3e00:dc04:227f:4339:1e78? ([2602:47:d950:3e00:dc04:227f:4339:1e78]) by smtp.gmail.com with ESMTPSA id e5-20020a0cf745000000b0067a0eecf4easm2787186qvo.31.2023.12.10.15.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 15:31:04 -0800 (PST) Message-ID: <3a2be586-89ce-4eac-b889-2a6cd8a38d72@gmail.com> Date: Sun, 10 Dec 2023 18:31:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] incompatible-poiner-types bug fixes To: Bart Schaefer Cc: zsh-workers@zsh.org References: Content-Language: en-US From: Nicholas Vinson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Seq: 52403 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: If configure incorrectly decides (or is incorrectly told) that boolcodes or numcodes do not exist, you end up with a naming conflict at compile-time. This happened while I was testing my changes. I suspect, but don't know for sure, that this also happened at some point with strcodes since the handling of that variable is different than how boolcodes and numcodes are handled. Regardless, the naming change prevents the naming conflict, and the defines prevent added complexity on the for-loops and simplifies the strcodes for-loop handling. Moreover, these changes align the handling of all three variables, boolcodes, numcodes, strcodes, in a type-safe and name-safe manner. Thanks, Nicholas Vinson On 12/10/23 17:45, Bart Schaefer wrote: > On Sun, Dec 10, 2023 at 1:50 PM Nicholas Vinson wrote: >> This patch series fixes several bugs found by compiling with >> -Werror=incompatible-pointer-types. > We've already got a patch for this from Florian Weimer > in workers/52383. Is the zboolcodes naming and > BOOLCODES define in Src/Modules/termcap.c actually necessary?