zsh-workers
 help / color / mirror / code / Atom feed
From: "Lawrence Velázquez" <larryv@zsh.org>
To: "Philippe Altherr" <philippe.altherr@gmail.com>
Cc: "Bart Schaefer" <schaefer@brasslantern.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] NEWS item about the ERR_EXIT fixes
Date: Sat, 10 Dec 2022 02:35:34 -0500	[thread overview]
Message-ID: <3d480e25-9eae-439a-b2e3-9bbf0a2949c3@app.fastmail.com> (raw)
In-Reply-To: <CAGdYchuG_D42UeDS3ernSfPsaYCarRxuZnBha2Tq=3OJQrdJvg@mail.gmail.com>

On Fri, Dec 9, 2022, at 4:30 AM, Philippe Altherr wrote:
>> +  - Function calls, anonymous functions, and the `eval`, `.`, and
>> +    `source` commands no longer propagate ERR_EXIT suppression.
>
> This kind of suggests that these constructs always propagated the 
> suppression, which isn't the case, but the exact circumstances look too 
> complex to explain. Maybe replace "no longer" with "now never".

What were the circumstances under which they previously propagated
suppression?

>> +The ERR_RETURN option is now suppressed when a function containing
>> +a compound sublist (`&&` or `||`) is called from within another compound
>> +sublist.
>
>  I find this a bit cryptic. It may also give the wrong impression that 
> functions containing a compound sublist are a special case. And 
> finally, the same is true for functions called in if/while conditions.

I admit that I don't fully understand what this commit did, so I
more or less copied the entry Bart added to ChangeLog:

	* Philippe Altherr: 51071: Src/exec.c, Test/C03traps.ztst: fix
	ERR_RETURN when a function using && / || is called within another
	statement using && / ||

That's not accurate either, then?

-- 
vq


  parent reply	other threads:[~2022-12-10  7:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 21:45 Philippe Altherr
2022-12-09  0:24 ` Bart Schaefer
2022-12-09  6:44   ` Lawrence Velázquez
2022-12-09  9:30     ` Philippe Altherr
2022-12-09 15:17       ` Mikael Magnusson
2022-12-10  7:23         ` Lawrence Velázquez
2022-12-10  7:35       ` Lawrence Velázquez [this message]
2022-12-10 11:32     ` Daniel Shahaf
2022-12-10 13:49       ` Philippe Altherr
2022-12-11  3:32         ` Lawrence Velázquez
2022-12-13  0:33           ` Philippe Altherr
2022-12-13  3:05             ` Daniel Shahaf
2022-12-11  3:23       ` Lawrence Velázquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d480e25-9eae-439a-b2e3-9bbf0a2949c3@app.fastmail.com \
    --to=larryv@zsh.org \
    --cc=philippe.altherr@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).