From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18220 invoked from network); 10 Dec 2022 07:36:17 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 10 Dec 2022 07:36:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=4vGLv57axOHed1RgL694Wnnpo4IK4aimROrXvWbHYJw=; b=bwlJ23tEG5NmeGgxXrCKgXQWcv CnRfpiWVwSLfb7Nc6rXWIkIuCMDB49sW3A21fJuXO2LZuUD71nj72w52rIXEd9KPOlGhoEFBDMO78 6/hZZkPDk/ZibH3m+PFbvsysFHmnRYNcZaq0EkMTvEokWLnq5ftlzreeLw+4/cDUijJA5nAjwAk4/ jEeS5qb+UwmhejcJCbr/gtovYxDWNWkexHDvUaS5onMYS9r2PCOwDcu6flCbkDvn686J7ZG6GO4Vq sMu9OF2+kCvKGzRmhnW179FmIrQocyFWJSYroCB0RtXVX63hWDKLQJI0Gw4omtLBJ4t2nl93aTe11 EIwuoHcg==; Received: by zero.zsh.org with local id 1p3uP9-000Dlb-8U; Sat, 10 Dec 2022 07:36:15 +0000 Received: by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1p3uOy-000DTL-FL; Sat, 10 Dec 2022 07:36:04 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailauth.nyi.internal (Postfix) with ESMTP id 0294927C0054; Sat, 10 Dec 2022 02:36:03 -0500 (EST) Received: from imap48 ([10.202.2.98]) by compute1.internal (MEProxy); Sat, 10 Dec 2022 02:36:03 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefgdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderreejnecuhfhrohhmpefnrgif rhgvnhgtvgcugggvlhojiihquhgviicuoehlrghrrhihvhesiihshhdrohhrgheqnecugg ftrfgrthhtvghrnhepleekheejgfdufeegkeeugedugefhvedvleejheeiueffheevjefg heethfduvefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheplhgrrhhrhihvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduudeh udekjeejtdegqdduudelvdejfeekhedqlhgrrhhrhihvpeepiihshhdrohhrghesfhgrsh htmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: iaa214773:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id A6B2631A0063; Sat, 10 Dec 2022 02:36:02 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Mime-Version: 1.0 Message-Id: <3d480e25-9eae-439a-b2e3-9bbf0a2949c3@app.fastmail.com> In-Reply-To: References: <46fcb939-0ed9-4b51-959d-67339181e3e3@app.fastmail.com> Date: Sat, 10 Dec 2022 02:35:34 -0500 From: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= To: "Philippe Altherr" Cc: "Bart Schaefer" , zsh-workers@zsh.org Subject: Re: [PATCH] NEWS item about the ERR_EXIT fixes Content-Type: text/plain X-Seq: 51164 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Fri, Dec 9, 2022, at 4:30 AM, Philippe Altherr wrote: >> + - Function calls, anonymous functions, and the `eval`, `.`, and >> + `source` commands no longer propagate ERR_EXIT suppression. > > This kind of suggests that these constructs always propagated the > suppression, which isn't the case, but the exact circumstances look too > complex to explain. Maybe replace "no longer" with "now never". What were the circumstances under which they previously propagated suppression? >> +The ERR_RETURN option is now suppressed when a function containing >> +a compound sublist (`&&` or `||`) is called from within another compound >> +sublist. > > I find this a bit cryptic. It may also give the wrong impression that > functions containing a compound sublist are a special case. And > finally, the same is true for functions called in if/while conditions. I admit that I don't fully understand what this commit did, so I more or less copied the entry Bart added to ChangeLog: * Philippe Altherr: 51071: Src/exec.c, Test/C03traps.ztst: fix ERR_RETURN when a function using && / || is called within another statement using && / || That's not accurate either, then? -- vq