From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18049 invoked from network); 7 Mar 2021 21:43:29 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Mar 2021 21:43:29 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1615153409; b=weoEUwr6X/DFoW2eDOyL1xUVhclN14r08b+33SIKlvcIKWQD/fhWMNNUeCFbDhv2+rXx3E5jfR kYvcCu3J0CN1KB8TjOY2QH/2ab9HXMr3ONhSPsSnKaLdaGJqO1Yv1IND0LAShveCId+TXLq4P8 bW/qngjjaviA+LKk5YMQlwsHJfSM4DlMooD7lD+VECbkPt8AXrShK5IU4GS1vuGFCIlYczY2l2 8Pse6DkhnAhClaKG+EhJRP5wz6sGWlDkIapL1HCQJoQBA22u+GYdoQMNSGejkIzk/foOGvSExi yrlUhadhRGX3ZyqrblfcLblvBT7BlkwmwG0CJa0N6tH3/g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1615153409; bh=e774TQ482FWmPtZlUfT6HayLDrrgBftunanDbt7xEgU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Subject:Cc:To:From: Date:References:In-Reply-To:Message-ID:MIME-Version:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=T1qjF8htWTSDUUepsLuHz8nTI+4hoRNzFjtljnfYJf4BgBmthDBU/RbXcxWwsoEj10IKoDmP5K qx1ZQL+Ti2Su88z2mfvA+F9iz+32pdIMoe6EDsYm7ZQ2ZzbyFJswTmsJ+D7rtwWsdK5NDtvA/G YbzEzwTrYgi2Mu6H51x+buFOcjSopZLXuungB92ZqkPQJMvREEui2wHt3O1gZL9cB0yEqddN4u vwgu8fhfSbYA+0e4jg5aPJ8rdvN2BAKJ7ccb3zoZxKpRRfFEA1lUQwbtW0Xs6mBdsqrw4d8eCb b2UuwnekBwddxU3j7/TL3l3LwRqlqyfpFbuVzqCmnIWRPA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To:Message-Id: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=qx6lN641T8Vr9+mkR20UYr2Xci+cjJF7HeZJc26m9Nw=; b=RGW3bQzukFMh2V6PKeLC4EkAiY wMuWrY5VOxezCL4sE2VA0eyze0s3pCLBO5Y24HGrWflLdXhYUyZZlOWp4n0dZnfCCAoQzQfplUCE1 nbixpO7T493eMh5PxMV3D7+Ow3VQAMIxEbssYH1OwlxDjK6yyq7sMWVPgWm3fqqgKwyL3Ot25xrQd 2iRXf73LD2oY89zG+Zh3ocVSsmrCkeKlP1Ef4CJTyLz4PaKEwK/vu9tYrQNAlhlTcKJAm3+Z+8WlB bm91FlIJJqMW0ogWvh7GfPATZHZukjj/NfZnsc4n8tZeHqIw1wjnJDvCu/Xz8fJVeSSaG6cn+bTHK IX5VnsOA==; Received: from authenticated user by zero.zsh.org with local id 1lJ1BQ-0000Pk-NK; Sun, 07 Mar 2021 21:43:28 +0000 Authentication-Results: zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39237) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lJ1BD-0000G2-RM; Sun, 07 Mar 2021 21:43:17 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E83B15C00DB; Sun, 7 Mar 2021 16:43:07 -0500 (EST) Received: from imap37 ([10.202.2.87]) by compute3.internal (MEProxy); Sun, 07 Mar 2021 16:43:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:cc:subject:content-type :content-transfer-encoding; s=fm2; bh=qx6lN641T8Vr9+mkR20UYr2Xci +cjJF7HeZJc26m9Nw=; b=FMSkw4K2ysz/Wdv0yW03BPNdlZ3W/dGK2bJduZQOTs uUTgn1rgmLwADE8I9jTJtDisVoPqMvDIR7HMmSFAkPwnjFoALKEVRblNKIH9uJff 7wsXkztz8iMF4Eb5TyYT60N9casCyZBndjpq9YXJ8xuAE3rE4DwwC9kzMp9b95j+ OhfSu6w58t88JOBXiZVkADs1r10q5O9H8gTqy/eSFqeEQr0DhQ9TL2/Lrd1f69nb aohZU8vOB+yeKNpd6j9dnEiKDk/1urs8eHE27TSdMamp9lvY40j+URg6Q88LjHpr 8mxxqfmc3S8iIm+mzGkENeFmE7mYepIKOY/aWK1bSkdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qx6lN641T8Vr9+mkR20UYr2Xci+cjJF7HeZJc26m9 Nw=; b=VYbhryAiCbnE0PS5wHpgmZTFyxnEZZRyVxjbk3h9Zw/OwAFIleutmIj4o QNA2HEhPjAOmMpZNr9ZWFEJhfmiSOEEdmm8v36pyRbXb0dNp8lxbN3z8UV0z2wma mmWlvr6AKOhA/Ucy9B6xG/5RlAfhaWQGHQnG/+7UP5NGI++zdEJA2sz5qmXzd9Qw 8/vUGtGqimIvIlLfFryUl5lz7IvlXVjFqsniwFg3CzluDgHkG5VAMx2TW6OrSLgI h4fvNvOV41kEsosHXxSOLmpTWq1Fb7YzU9bynnEqK8WhA4QQjceLheKCgwUIFh9N QHTUtmd25SGtnLGdHbvt/3CcEeUFA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddutddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepfdff rghnihgvlhcuufhhrghhrghffdcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrg hmvgeqnecuggftrfgrthhtvghrnhepfefhkeefveeileelheeiffdtkedujeelvdfhtdej tdeggedvuefffeelhefhvdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8F95F6B40061; Sun, 7 Mar 2021 16:43:07 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-206-g078a48fda5-fm-20210226.001-g078a48fd Mime-Version: 1.0 Message-Id: <3e0a754f-bbac-404d-92ba-b30f0c736f61@www.fastmail.com> In-Reply-To: References: <31598-1614116362.902856@aI-l.maGv.3QD7> <20210224142437.GC9342@tarpaulin.shahaf.local2> Date: Sun, 07 Mar 2021 21:42:47 +0000 From: "Daniel Shahaf" To: "Jacob Gelbman" Cc: zsh-workers@zsh.org Subject: Re: Completion script for the ctags program Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Seq: 48152 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Thanks for the revision. Not a full review; just two points: Jacob Gelbman wrote on Sun, 07 Mar 2021 19:18 +00:00: > > On Feb 24, 2021, at 8:24 AM, Daniel Shahaf = wrote: > > Jacob Gelbman wrote on Wed, Feb 24, 2021 at 01:20:24 -0600: > >> "--fields=3D[include selected extension fields (flags afmikKlnsS= tz)]:flags" > >=20 > > Recommend to move the afmikKlnsStz thing to after the colon, so it'l= l be > > shown at a more appropriate point. Also, it would be helpful to dis= play > > descriptions to the flags using, e.g., =C2=ABcompset=C2=BB (for the = leading plus > > sign) followed by =C2=AB_values -s ''=C2=BB. >=20 > I moved the possible values to the argument description, but I don=E2=80= =99t=20 > have enough time to figure out how to complete them automatically righ= t=20 > now. Like this: _f() { _arguments : '--foo:bar: _values -s "" baz "a[access]" "f[file]" = "i[inheritance]"' } > >> elif [ "$state" =3D "languages" ]; then > >> _values -s , languages $languages > >=20 > > Don't pass unsanitized command output to a builtin. I don't know th= e > > fix off the top of my head. This point has been neither responded to nor implemented. Daniel