From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: Use of ${words[0]} in completion functions
Date: Wed, 14 Jan 2004 16:49:51 +0100 [thread overview]
Message-ID: <4044.1074095391@gmcs3.local> (raw)
In-Reply-To: <1040111175159.ZM20622@candle.brasslantern.com>
On 11 Jan, Bart wrote:
> I just noticed that a couple of completion functions use ${words[0]} as
> the command name. That's a little misleading -- and maybe even a bug
> waiting to happen -- because $_comp_options contains NO_ksharrays, and
> neither of these functions resets it.
>
> Completion/Unix/Type/_perl_modules:33: local perl=${words[0]%doc} perl_modules
I'd agree that's potentially misleading. Patch below.
> Completion/bashcompinit:123: $OPTARG "${words[0]}" "${words[CURRENT-1]}" "${words[CURRENT-2]}"
There is an `emulate -L sh' in the function here so that looks right to
me.
Oliver
Index: Completion/Unix/Type/_perl_modules
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_perl_modules,v
retrieving revision 1.2
diff -u -r1.2 _perl_modules
--- Completion/Unix/Type/_perl_modules 16 Apr 2002 07:48:46 -0000 1.2
+++ Completion/Unix/Type/_perl_modules 14 Jan 2004 15:40:46 -0000
@@ -30,7 +30,7 @@
_perl_modules_caching_policy
fi
- local perl=${words[0]%doc} perl_modules
+ local perl=${words[1]%doc} perl_modules
if whence $perl >/dev/null; then
perl_modules=_${${perl//[^[:alnum:]]/_}#_}_modules
elif (( ${+commands[perl]} )); then
prev parent reply other threads:[~2004-01-14 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-11 17:51 Bart Schaefer
2004-01-14 15:49 ` Oliver Kiddle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4044.1074095391@gmcs3.local \
--to=okiddle@yahoo.co.uk \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).