* Use of ${words[0]} in completion functions
@ 2004-01-11 17:51 Bart Schaefer
2004-01-14 15:49 ` Oliver Kiddle
0 siblings, 1 reply; 2+ messages in thread
From: Bart Schaefer @ 2004-01-11 17:51 UTC (permalink / raw)
To: zsh-workers
I just noticed that a couple of completion functions use ${words[0]} as
the command name. That's a little misleading -- and maybe even a bug
waiting to happen -- because $_comp_options contains NO_ksharrays, and
neither of these functions resets it.
Completion/Unix/Type/_perl_modules:33: local perl=${words[0]%doc} perl_modules
Completion/bashcompinit:123: $OPTARG "${words[0]}" "${words[CURRENT-1]}" "${words[CURRENT-2]}"
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Use of ${words[0]} in completion functions
2004-01-11 17:51 Use of ${words[0]} in completion functions Bart Schaefer
@ 2004-01-14 15:49 ` Oliver Kiddle
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Kiddle @ 2004-01-14 15:49 UTC (permalink / raw)
To: Bart Schaefer; +Cc: zsh-workers
On 11 Jan, Bart wrote:
> I just noticed that a couple of completion functions use ${words[0]} as
> the command name. That's a little misleading -- and maybe even a bug
> waiting to happen -- because $_comp_options contains NO_ksharrays, and
> neither of these functions resets it.
>
> Completion/Unix/Type/_perl_modules:33: local perl=${words[0]%doc} perl_modules
I'd agree that's potentially misleading. Patch below.
> Completion/bashcompinit:123: $OPTARG "${words[0]}" "${words[CURRENT-1]}" "${words[CURRENT-2]}"
There is an `emulate -L sh' in the function here so that looks right to
me.
Oliver
Index: Completion/Unix/Type/_perl_modules
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_perl_modules,v
retrieving revision 1.2
diff -u -r1.2 _perl_modules
--- Completion/Unix/Type/_perl_modules 16 Apr 2002 07:48:46 -0000 1.2
+++ Completion/Unix/Type/_perl_modules 14 Jan 2004 15:40:46 -0000
@@ -30,7 +30,7 @@
_perl_modules_caching_policy
fi
- local perl=${words[0]%doc} perl_modules
+ local perl=${words[1]%doc} perl_modules
if whence $perl >/dev/null; then
perl_modules=_${${perl//[^[:alnum:]]/_}#_}_modules
elif (( ${+commands[perl]} )); then
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-01-14 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-11 17:51 Use of ${words[0]} in completion functions Bart Schaefer
2004-01-14 15:49 ` Oliver Kiddle
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).