From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24872 invoked by alias); 26 Mar 2018 20:32:59 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42538 Received: (qmail 24792 invoked by uid 1010); 26 Mar 2018 20:32:59 -0000 X-Qmail-Scanner-Diagnostics: from kahlil.inlv.org by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(37.59.109.123):SA:0(-1.9/5.0):. Processed in 1.959425 secs); 26 Mar 2018 20:32:59 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: martijn@inlv.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Subject: Re: [PATCH] make sure internal temp files are user readable and writeable To: zsh-workers@zsh.org References: <581009fe-372c-641a-cf5f-87e6a2a68dbb@inlv.org> <20180326170044.GA10044@chaz.gmail.com> From: Martijn Dekker Message-ID: <41233f43-9695-3b82-888f-5cad9cb2ca47@inlv.org> Date: Mon, 26 Mar 2018 22:32:50 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------3DDAFFA69452C3840B8FA065" Content-Language: en-GB --------------3DDAFFA69452C3840B8FA065 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Op 26-03-18 om 19:37 schreef Martijn Dekker: > Op 26-03-18 om 19:00 schreef Stephane Chazelas: >> Thanks. See also 42446 >> (https://www.zsh.org/mla/workers/2018/msg00252.html) >> with other suggested options. > > Ah yes, sorry, forgot you'd already brought it up here. Re-reading that, my thought is: while option 2 might be nice to have, option 4 is the simple, obvious and immediate fix, so that's the one I'm capable of providing -- especially with a release imminent. If you'd like to have a go at implementing option 2, so much the better. >> There I mentioned the potential need to block signals between >> the time the umask is changed temporarily and when it's restored >> (to avoid traps running with the wrong umask (0177 instead of >> the user's requested one)). > > Good point. > > Please consider my patch withdrawn. Today was apparently not my best day. Since that function was already blocking (a.k.a. queueing) signals to do its thing, of course my patch was trivial to fix. Take 2. - M. --------------3DDAFFA69452C3840B8FA065 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="heredoc-umask.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="heredoc-umask.patch" ZGlmZiAtLWdpdCBhL1NyYy91dGlscy5jIGIvU3JjL3V0aWxzLmMKaW5kZXggNjUxN2UxNS4u NDY2MDE0MiAxMDA2NDQKLS0tIGEvU3JjL3V0aWxzLmMKKysrIGIvU3JjL3V0aWxzLmMKQEAg LTIxNzcsMTAgKzIxNzcsMTIgQEAgZ2V0dGVtcGZpbGUoY29uc3QgY2hhciAqcHJlZml4LCBp bnQgdXNlX2hlYXAsIGNoYXIgKip0ZW1wbmFtZSkKIHsKICAgICBjaGFyICpmbjsKICAgICBp bnQgZmQ7CisgICAgbW9kZV90IG9sZF91bWFzazsKICNpZiBIQVZFX01LU1RFTVAKICAgICBj aGFyICpzdWZmaXggPSBwcmVmaXggPyAiLlhYWFhYWCIgOiAiWFhYWFhYIjsKIAogICAgIHF1 ZXVlX3NpZ25hbHMoKTsKKyAgICBvbGRfdW1hc2sgPSB1bWFzaygwMTc3KTsKICAgICBpZiAo IXByZWZpeCAmJiAhKHByZWZpeCA9IGdldHNwYXJhbSgiVE1QUFJFRklYIikpKQogCXByZWZp eCA9IERFRkFVTFRfVE1QUFJFRklYOwogICAgIGlmICh1c2VfaGVhcCkKQEAgLTIxOTgsNiAr MjIwMCw3IEBAIGdldHRlbXBmaWxlKGNvbnN0IGNoYXIgKnByZWZpeCwgaW50IHVzZV9oZWFw LCBjaGFyICoqdGVtcG5hbWUpCiAgICAgaW50IGZhaWx1cmVzID0gMDsKIAogICAgIHF1ZXVl X3NpZ25hbHMoKTsKKyAgICBvbGRfdW1hc2sgPSB1bWFzaygwMTc3KTsKICAgICBkbyB7CiAJ aWYgKCEoZm4gPSBnZXR0ZW1wbmFtZShwcmVmaXgsIHVzZV9oZWFwKSkpIHsKIAkgICAgZmQg PSAtMTsKQEAgLTIyMTIsNiArMjIxNSw3IEBAIGdldHRlbXBmaWxlKGNvbnN0IGNoYXIgKnBy ZWZpeCwgaW50IHVzZV9oZWFwLCBjaGFyICoqdGVtcG5hbWUpCiAjZW5kaWYKICAgICAqdGVt cG5hbWUgPSBmbjsKIAorICAgIHVtYXNrKG9sZF91bWFzayk7CiAgICAgdW5xdWV1ZV9zaWdu YWxzKCk7CiAgICAgcmV0dXJuIGZkOwogfQpkaWZmIC0tZ2l0IGEvVGVzdC9BMDRyZWRpcmVj dC56dHN0IGIvVGVzdC9BMDRyZWRpcmVjdC56dHN0CmluZGV4IGVmN2RkYjIuLmI1YjY1Y2Yg MTAwNjQ0Ci0tLSBhL1Rlc3QvQTA0cmVkaXJlY3QuenRzdAorKysgYi9UZXN0L0EwNHJlZGly ZWN0Lnp0c3QKQEAgLTY2NywzICs2NjcsMTIgQEAKIDA6UmVkaXJlY3QgaW4gdGhlIG1pZGRs ZSBvZiBhc3NpZ25tZW50cwogPmIKID5kCisKKyAgdW1hc2sgMDc3NworICBjYXQgPDwnICBI RVJFJworICBsb29rIG1hLCBubyBwZXJtaXNzaW9ucworICBIRVJFCisgIGNhdCA8PDwiaXQn cyBhIG1pcmFjbGUiCiswOkhlcmUte3N0cmluZyxkb2N1bWVudH1zIHN1Y2NlZWQgd2l0aCBy ZXN0cmljdGl2ZSB1bWFzaworPiAgbG9vayBtYSwgbm8gcGVybWlzc2lvbnMKKz5pdCdzIGEg bWlyYWNsZQo= --------------3DDAFFA69452C3840B8FA065--