zsh-workers
 help / color / mirror / code / Atom feed
* [BUG] `bindkey -M menuselect '^M' send-break` doesn't do what it says in the manual
@ 2021-08-16 13:26 Marlon Richert
  2021-08-26 10:29 ` Oliver Kiddle
  0 siblings, 1 reply; 3+ messages in thread
From: Marlon Richert @ 2021-08-16 13:26 UTC (permalink / raw)
  To: Zsh hackers list

According to `man 1 zshmodules`:

>      send-break
>             leaves menu selection and restores the previous contents of  the
>             command line
>
>      [...] For example, to make the return key  leave
>      menu selection without accepting the match currently selected one could
>      call
>             bindkey -M menuselect '^M' send-break
>
>      after loading the zsh/complist module.

However, while using send-break during menu selection does exit the
completion menu, it does _not_ restore the previous contents of the
command line and in fact leaves the current selection in place.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] `bindkey -M menuselect '^M' send-break` doesn't do what it says in the manual
  2021-08-16 13:26 [BUG] `bindkey -M menuselect '^M' send-break` doesn't do what it says in the manual Marlon Richert
@ 2021-08-26 10:29 ` Oliver Kiddle
  2021-08-27 14:34   ` Marlon Richert
  0 siblings, 1 reply; 3+ messages in thread
From: Oliver Kiddle @ 2021-08-26 10:29 UTC (permalink / raw)
  To: Marlon Richert; +Cc: Zsh hackers list

On 16 Aug, Marlon Richert wrote:
> According to `man 1 zshmodules`:
>
> >      send-break
> >             leaves menu selection and restores the previous contents of  the
> >             command line

> However, while using send-break during menu selection does exit the
> completion menu, it does _not_ restore the previous contents of the
> command line and in fact leaves the current selection in place.

In my testing, both with my setup and starting from zsh -f, it does
behave as documented. Are you able to bisect your setup to find a cause
or provide a list of commands to reproduce it starting from a blank
setup?

Oliver


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] `bindkey -M menuselect '^M' send-break` doesn't do what it says in the manual
  2021-08-26 10:29 ` Oliver Kiddle
@ 2021-08-27 14:34   ` Marlon Richert
  0 siblings, 0 replies; 3+ messages in thread
From: Marlon Richert @ 2021-08-27 14:34 UTC (permalink / raw)
  To: Oliver Kiddle; +Cc: Zsh hackers list

On Thu, Aug 26, 2021 at 1:29 PM Oliver Kiddle <opk@zsh.org> wrote:
>
> On 16 Aug, Marlon Richert wrote:
> > According to `man 1 zshmodules`:
> >
> > >      send-break
> > >             leaves menu selection and restores the previous contents of  the
> > >             command line
>
> > However, while using send-break during menu selection does exit the
> > completion menu, it does _not_ restore the previous contents of the
> > command line and in fact leaves the current selection in place.
>
> In my testing, both with my setup and starting from zsh -f, it does
> behave as documented. Are you able to bisect your setup to find a cause
> or provide a list of commands to reproduce it starting from a blank
> setup?

I can reproduce my case with the current master branch in a clean environment:

% exec -c zsh -fc "TERM=$TERM PS1='%# ' exec Src/zsh -f"
% zmodload zsh/complist
% autoload compinit
% compinit
% bindkey -M menuselect '^M' send-break
% bindkey '^I' menu-select
% cd /<Tab><Enter>
% cd /bin/

After pressing Tab and then Enter, `cd /bin/` is left on the command
line, instead of `cd /`. The same happens if I press Tab and then
Ctrl-G.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-27 14:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 13:26 [BUG] `bindkey -M menuselect '^M' send-break` doesn't do what it says in the manual Marlon Richert
2021-08-26 10:29 ` Oliver Kiddle
2021-08-27 14:34   ` Marlon Richert

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).