From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: Anybody know what's going on here in _expand? Patch?
Date: Sat, 28 Dec 2013 00:08:46 +0900 [thread overview]
Message-ID: <422747FD-94DA-48DC-A394-B1ADC31F0254@kba.biglobe.ne.jp> (raw)
In-Reply-To: <131226170827.ZM31040@torch.brasslantern.com>
> then I propose the following patch, which adds the seemingly missing
> backreference parens as well as putting quote chars in the class.
I believe the lack of the backreference paren is definitely a bug.
I guess the reason that this seemingly-rather-serious bug has not
been noticed so far is:
match[1] is set at lines 90-91 (where the pattern has a correct
pair of back-reference parentheses), and its value is NOT rest at
line 106 (where there are no back-reference parentheses).
The value is re-used at line 107, and in many (or all?) cases the
value is correct (a single space for most of the cases).
prev parent reply other threads:[~2013-12-27 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 1:08 Bart Schaefer
2013-12-27 15:08 ` Jun T. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422747FD-94DA-48DC-A394-B1ADC31F0254@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).