From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3249 invoked by alias); 27 Dec 2013 15:09:34 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32187 Received: (qmail 8582 invoked from network); 27 Dec 2013 15:09:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Biglobe-Sender: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Anybody know what's going on here in _expand? Patch? From: "Jun T." In-Reply-To: <131226170827.ZM31040@torch.brasslantern.com> Date: Sat, 28 Dec 2013 00:08:46 +0900 Content-Transfer-Encoding: 7bit Message-Id: <422747FD-94DA-48DC-A394-B1ADC31F0254@kba.biglobe.ne.jp> References: <131226170827.ZM31040@torch.brasslantern.com> To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.1827) > then I propose the following patch, which adds the seemingly missing > backreference parens as well as putting quote chars in the class. I believe the lack of the backreference paren is definitely a bug. I guess the reason that this seemingly-rather-serious bug has not been noticed so far is: match[1] is set at lines 90-91 (where the pattern has a correct pair of back-reference parentheses), and its value is NOT rest at line 106 (where there are no back-reference parentheses). The value is re-used at line 107, and in many (or all?) cases the value is correct (a single space for most of the cases).