Re: zsh 4.2.5

Re: zsh 4.2.5

[Zvi Har'El]

Installing zsh-4.2.5 on SOlaris 8 and 9, I had to add -liconv manualy to the
linkage:

--- Makefile.~20050406210938~ 2005-04-07 00:09:38.000000000 +0300
+++ Makefile    2005-04-07 00:16:04.575848000 +0300
@@ -127,7 +127,7 @@
 DLLDFLAGS       = -G
 LIBLDFLAGS      =  -s
 EXELDFLAGS      =  -s
-LIBS            = -lsocket -ldl -lnsl -lcurses -lm  -lc
+LIBS            = -liconv -lsocket -ldl -lnsl -lcurses -lm  -lc
 DL_EXT          = so
 DLLD            = gcc
 EXPOPT          = 


I suppose this requires some fixing in the configuration process, since
solaris doesn't have the gnu glibc, and the solaris libc doesn't include
iconv.

Best,

Zvi.

On Wed, 06 Apr 2005 12:25:01 +0100, Peter Stephenson wrote about "zsh 4.2.5":
> zsh version 4.2.5 is now available at ftp.zsh.org and Sourceforge.
> 
> This fixes some configuration problems and few other minor bugs.  I'm
> not aware of any incompatibilities that would be introduced by upgrading
> from 4.2.4.
> 
> -- 
> Peter Stephenson <pws@csr.com>                  Software Engineer
> CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
> Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070
> 
> 
> **********************************************************************
> This email and any files transmitted with it are confidential and
> intended solely for the use of the individual or entity to whom they
> are addressed. If you have received this email in error please notify
> the system manager.
> 
> **********************************************************************

-- 
Dr. Zvi Har'El      mailto:rl@math.technion.ac.il    Department of Mathematics
tel:+972-54-4227607 icq:179294841    Technion - Israel Institute of Technology
fax:+972-4-8293388  http://www.math.technion.ac.il/~rl/    Haifa 32000, ISRAEL
"If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
                             Thursday, 27 Adar II 5765,  7 April 2005, 12:18AM

Re: zsh 4.2.5

[Oliver Kiddle]

"Zvi Har'El" wrote:
> I suppose this requires some fixing in the configuration process, since
> solaris doesn't have the gnu glibc, and the solaris libc doesn't include
> iconv.

Certainly on the Solaris machines I have access to, libc does include
iconv. Is the iconv library you're trying to link against GNU libiconv?
What error were you getting? Is it perhaps picking up GNU libiconv's
include files before the system ones?

What happens if you type in the following:
  cat > t.c <<END
  #include <iconv.h>
  main() { iconv_t cd = (iconv_t)iconv_open("646", "8859"); }
  END
  cc t.c
For me, that compiles just fine.

Oliver

Re: zsh 4.2.5

[Dan Nelson]

In the last episode (Apr 07), Oliver Kiddle said:
> "Zvi Har'El" wrote:
> > I suppose this requires some fixing in the configuration process,
> > since solaris doesn't have the gnu glibc, and the solaris libc
> > doesn't include iconv.
> 
> Certainly on the Solaris machines I have access to, libc does include
> iconv. Is the iconv library you're trying to link against GNU
> libiconv? What error were you getting? Is it perhaps picking up GNU
> libiconv's include files before the system ones?
> 
> What happens if you type in the following:
>   cat > t.c <<END
>   #include <iconv.h>
>   main() { iconv_t cd = (iconv_t)iconv_open("646", "8859"); }
>   END
>   cc t.c
> For me, that compiles just fine.

He's probably got libiconv installed and using gcc which defaults to
having /usr/local/include *before* /usr/include in the search path!! 
Both sunfreeware.com's version for Solaris 9 and the one bundled with
Solaris 10 do this.  Remove or rename /usr/local/include/iconv.h.

-- 
	Dan Nelson
	dnelson@allantgroup.com

Re: zsh 4.2.5

[Oliver Kiddle]

Dan Nelson wrote:

> He's probably got libiconv installed and using gcc which defaults to
> having /usr/local/include *before* /usr/include in the search path!! 
> Both sunfreeware.com's version for Solaris 9 and the one bundled with
> Solaris 10 do this.  Remove or rename /usr/local/include/iconv.h.

Okay, so we need to find out if iconv.h comes from libiconv. That's
probably easiest done by checking whether it defines _LIBICONV_H or
_LIBICONV_VERSION using AC_CHECK_DECL. The following patch does that.

If testing this on a suitable Solaris installation (with libiconv and
gcc), note that you'll need LD_LIBRARY_PATH to contain /usr/local/lib.
(otherwise the later tcsetpgrp() test fails to run because it needs to
find the libiconv library). Should I perhaps use a separate ICONV_LIBS
variable?

Oliver

Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.31
diff -u -r1.31 configure.ac
--- configure.ac	4 Apr 2005 09:58:49 -0000	1.31
+++ configure.ac	7 Apr 2005 16:01:02 -0000
@@ -743,6 +743,10 @@
     if test "x$ac_found_iconv" != "xno"; then
       LIBS="-liconv $LIBS"
     fi
+  else
+    AC_CHECK_DECL(_libiconv_version,
+      [ AC_CHECK_LIB(iconv, libiconv, LIBS="-liconv $LIBS") ],,
+      [ #include <iconv.h> ])
   fi
 fi
 if test "x$ac_found_iconv" = xyes; then

Re: zsh 4.2.5

[Oliver Kiddle]

I wrote:
> Okay, so we need to find out if iconv.h comes from libiconv. That's

Sorry for following up to myself but there's a further point I thought
I'd mention. 

In zsh, iconv conversions are only done to the encoding used in the
current locale which is retrieved using nl_langinfo(CODESET). On Solaris
that returns things like "646" and "8859" which the native iconv
understands but libiconv doesn't. Anyone who is building on Solaris with
gcc and libiconv installed would probably be wise to use
CFLAGS=-I/usr/include. That also has the advantage that the resulting
binary will run on another Solaris box which lacks libiconv.

We could do things like attempting to normalise the output of
nl_langinfo(CODESET) but \u is only really useful when the encoding is
something like UTF-8 and that only has one name. It is also tempting to
suggest automatically digging around for the system iconv.h but it's
better to leave control in the hands of the user so they can have the
choice of using libiconv.

Oliver

Re: zsh 4.2.5

[Zvi Har'El]

Dear Dan,

You are completely right. I am using sunfreeware.com's version of gcc, 
and it finds /usr/local/include/iconv.h

Dan Nelson wrote:

>In the last episode (Apr 07), Oliver Kiddle said:
>  
>
>>"Zvi Har'El" wrote:
>>    
>>
>>>I suppose this requires some fixing in the configuration process,
>>>since solaris doesn't have the gnu glibc, and the solaris libc
>>>doesn't include iconv.
>>>      
>>>
>>Certainly on the Solaris machines I have access to, libc does include
>>iconv. Is the iconv library you're trying to link against GNU
>>libiconv? What error were you getting? Is it perhaps picking up GNU
>>libiconv's include files before the system ones?
>>
>>What happens if you type in the following:
>>  cat > t.c <<END
>>  #include <iconv.h>
>>  main() { iconv_t cd = (iconv_t)iconv_open("646", "8859"); }
>>  END
>>  cc t.c
>>For me, that compiles just fine.
>>    
>>
>
>He's probably got libiconv installed and using gcc which defaults to
>having /usr/local/include *before* /usr/include in the search path!! 
>Both sunfreeware.com's version for Solaris 9 and the one bundled with
>Solaris 10 do this.  Remove or rename /usr/local/include/iconv.h.
>
>  
>

-- 
Dr. Zvi Har'El      mailto:rl@math.technion.ac.il    Department of Mathematics
tel:+972-54-4227607 icq:179294841    Technion - Israel Institute of Technology
fax:+972-4-8293388  http://www.math.technion.ac.il/~rl/    Haifa 32000, ISRAEL
"If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)