From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: (qmail 10712 invoked from network); 25 Mar 2020 00:17:47 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from unknown (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTP; 25 Mar 2020 00:17:47 -0000 Received: (qmail 17278 invoked by alias); 25 Mar 2020 00:17:35 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45613 Received: (qmail 7141 invoked by uid 1010); 25 Mar 2020 00:17:34 -0000 X-Qmail-Scanner-Diagnostics: from rcpt-expgw.biglobe.ne.jp by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25758. spamassassin: 3.4.2. Clear:RC:0(133.208.98.4):SA:0(-2.6/5.0):. Processed in 1.285399 secs); 25 Mar 2020 00:17:34 -0000 X-Envelope-From: takimoto-j@kba.biglobe.ne.jp X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.208.98.4 as permitted sender) X-Biglobe-Sender: From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin Date: Wed, 25 Mar 2020 09:16:55 +0900 References: <82F8CDE0-C95C-4D31-ABFC-EBB3C97799F3@kba.biglobe.ne.jp> <1B509B1C-A670-482F-9D88-2145E15D03A1@kba.biglobe.ne.jp> <20200109131553.hqetnd45sc43z6xb@tarpaulin.shahaf.local2> <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp> <20200111201549.GA1264@tarpaulin.shahaf.local2> <3340070A-53DD-40F0-8363-A8C7D84702D3@kba.biglobe.ne.jp> <374cecf6-45d5-4688-861f-cc52017dbcea@www.fastmail.com> <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp> <20200320191846.3a4f5682@tarpaulin.shahaf.local2> <20200324024320.12bae9e9@tarpaulin.shahaf.local2> To: zsh-workers@zsh.org In-Reply-To: <20200324024320.12bae9e9@tarpaulin.shahaf.local2> Message-Id: <452D3122-F904-4A39-9E2E-31F3285C8019@kba.biglobe.ne.jp> X-Mailer: Apple Mail (2.3445.104.11) X-Biglobe-Spnum: 38259 > 2020/03/24 11:43, Daniel Shahaf wrote: > > Jun T wrote on Tue, 24 Mar 2020 10:33 +0900: >> >> I get the error message 'duplicate ulimit option letter' every time >> I start zsh. This may be quite annoying for ordinary users. > > That message is printed by the DPUTS1() macro. Whoops, sorry. I think only someone here (zsh-workers) will add a new resource, and I believe they will run the tests (but not sure they use --enable-zsh-debug). So just adding a test is sufficient, I think. # Typical use of DPUTS() is to find a not-easy-to-find bug (corner cases # etc.) which can be detected only by running zsh under various situations. # Duplicated option letter should/can be detected more earlier. As for the test: > 2020/03/21 2:02, Daniel Shahaf wrote: > >> + limit | grep UNKNOWN || print OK > > The "limit" builtin is provided by a module. As such, it can be > unavailable if the module had been disabled in config.modules prior to > building. So what the fix for this? Is it enough to skip the tests if loading rlimits module fails (because we are testing module features, not module loading)?