From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26578 invoked by alias); 9 Nov 2016 15:35:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39892 Received: (qmail 26325 invoked from network); 9 Nov 2016 15:35:24 -0000 X-Qmail-Scanner-Diagnostics: from mail-wm0-f50.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.82.50):SA:0(0.0/5.0):. Processed in 0.324415 secs); 09 Nov 2016 15:35:24 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: layus.on@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 74.125.82.50 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=oOoUMB0eX1z0ayG1q169imX2faB62ooF0A2BYg64T1g=; b=bu6fQo2pUYJu0K9OA/POC6zYxyOvgY280elJvntthOF+t3gb0xLmXCSTCSK3+PRnIn RRkU9sAR0HEBjvyozwrf9HY+5K/GurLgq5dtasCDFiQGHTTbm9ZBymnWsMBC6lUGsrVH LO5AHr2IV30sKa8he5mN4mLPBXyWQf3BJs92pUr6L0DShs1Y+YcYO7zbCuD1oqJiwHa/ o8b3h34UtiJUInLOwZ+UK5cNQ2vK2GxUF5XFyOLjzcuu9mJfVHNni+l96unbrsDHHYu7 3nd9hjb7ZskLx/Mxllopx+cc74nRDifQGUMG6qtPmqthQPPxqhExAe9zOH+EiWz9BZMo 1U/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=oOoUMB0eX1z0ayG1q169imX2faB62ooF0A2BYg64T1g=; b=hz533c88yivoBCIHfRhgsVE6iRb3QEW/YwP9rmumk9LEjUpkANPqEIOOHQ2+WHHw0k SMaCIstJyz7ojiFqrI2mmNGx0EzTMb2u6LSEc196sL/XzZLDzB6sONPvQxf2dX5rQzN6 Z8M7mi1zTROKUx/msviVMIo0WuQvjwBqG2rOXcf6GFkBAJNnFpep5ixRMigUOzSvT3Aa jPjoXTs5QxtT9O+6/dJnHdABYjh24K9K3J7gf4hKQgL1t3X4EsXjxrBlNdnagJ9NTKAy Cqjc8ha/GqRtd5RHhNd7B4zt5bNDni2TcCaPY3O7BF+6YjnPj6QOCnV567Sg0WiqhVmL Ydkw== X-Gm-Message-State: ABUngveo+S37kKD+dSeXMcgYUP3X126uJQTHA2a1EV7t6ipYz+vJ6tP1FKMEXVTS/Ac83A== X-Received: by 10.28.8.202 with SMTP id 193mr826288wmi.101.1478705716553; Wed, 09 Nov 2016 07:35:16 -0800 (PST) Subject: Re: [PATCH] make TERMINFO_DIRS variable special To: Peter Stephenson , zsh-workers@zsh.org References: <20161108202651.22527-1-layus.on@gmail.com> <20161109152617.6eb4658c@pwslap01u.europe.root.pri> From: "Guillaume Maudoux (Layus)" Message-ID: <4662e5f1-011e-f699-d0bd-788e913b1c93@gmail.com> Date: Wed, 9 Nov 2016 16:35:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161109152617.6eb4658c@pwslap01u.europe.root.pri> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Le 09/11/16 à 16:26, Peter Stephenson a écrit : > On Wed, 9 Nov 2016 15:47:10 +0100 > "Guillaume Maudoux (Layus)" wrote: >> The general idea is that terminfo look for these varibales via getenv(), >> To pass them correctly, we need to export them to our own environment. >> The term update is just a nice extra feature avoiding the TERM=$TERM trick. >> >> I am not aware of the review/accept policy for patches. >> Could you tell me if this one has any chance to get merged ? > Can't see any problem generally, given it's exactly parellel to the > TERMINFO trick. > > Usually you just need to post it (without the "> " and by any mechanism > that doesn't cause line wrap or other modifications) and wait for people > to comment. My initial mail contained only the patch, in the correct format. I then send a description, scrambling the patch... Seems like I am unable to get both right ;-). > One issue is that the doc implies (and people would probably expect) > that TERMINFO_DIRS is a tied variable with a terminfo_dirs array > equivalent. This doesn't exist. This would need accessors along the > lines of the contents of colonarr_gsu for the colon-separated version > and vararray_gsu for the array version. Possibly only the setters are > different. Would it be okay to change only the docs ? There is no reason to make TERMINFO_DIRS a tied variable. It's a basic raw variable passed to ncurses, not a widely used variable like $path. I just copied the description of some array variable, trying to be smart... I will submit the same patch with a better doc. > > pws layus