zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Cedric Ware <cedric.ware__bml@normalesup.org>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Enable sub-second timeout in zsystem flock
Date: Mon, 20 Apr 2020 12:28:09 -0500	[thread overview]
Message-ID: <46E15633-F786-4BB9-8429-F6B848552841@dana.is> (raw)
In-Reply-To: <20200418163216.ohqwhs4gwvnzqher@phare.normalesup.org>

On 18 Apr 2020, at 11:32, Cedric Ware <cedric.ware__bml@normalesup.org> wrote:
> I'm all for it, of course. ;-)  You decide whether you want the zlong
> one or the struct timespec one.

I'm not sure i'm qualified to have a strong opinion on the 32/64 thing, but it
sounds like both options have their merits, and nobody else has indicated a
preference, so i've merged the most recent patch. We can change it later if we
want.

I did make two small modifications:

* The documentation said that the time-out/interval values had to be *less
  than* 2^30-1 / 0.999*LONG_MAX, but as far as i can see from the code it's
  actually *less than or equal to*, so i changed the wording slightly. Please
  correct me if there's any mistake here

* I reverted the superscript formatting change that Daniel suggested. It looks
  like @sup was added to texinfo only in 2014, and Apple's makeinfo in
  particular does not support it. I was able to get Homebrew's texinfo package
  to work, but it's keg-only (not linked into PATH due to conflicts with other
  software), and i'm nervous about unilaterally breaking the Doc build with
  the standard tooling on macOS and possibly other platforms just to format
  one number. Not suggesting we limit ourselves to Apple's GPL2 tooling until
  the end of time, but i suppose we should at least discuss it first

dana


  reply	other threads:[~2020-04-20 17:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 20:35 Cedric Ware
2019-07-29 22:25 ` Bart Schaefer
2020-01-04 18:47   ` Cedric Ware
2020-01-05 18:42     ` dana
2020-01-05 21:49       ` dana
2020-01-06 17:30       ` Cedric Ware
2020-01-06 17:36         ` Peter Stephenson
2020-01-07  3:48         ` dana
2020-01-11 15:41           ` Cedric Ware
2020-01-11 19:36             ` dana
2020-01-12  4:25               ` dana
2020-03-08 18:39                 ` Cedric Ware
2020-03-12 18:46                   ` dana
2020-03-12 19:13                     ` dana
2020-03-14 21:04                     ` Cedric Ware
2020-03-15  0:50                       ` Daniel Shahaf
2020-03-15  1:04                         ` dana
2020-03-15 16:03                         ` Cedric Ware
2020-03-15 16:54                           ` Daniel Shahaf
2020-03-15 17:35                             ` Peter Stephenson
2020-03-15 18:36                             ` Cedric Ware
2020-03-15 19:13                               ` Daniel Shahaf
2020-04-13 21:34                             ` Cedric Ware
2020-04-14 11:47                               ` Daniel Shahaf
2020-04-14 20:21                                 ` Cedric Ware
2020-04-15  1:15                                   ` Daniel Shahaf
2020-04-15  2:05                                     ` dana
2020-04-16  4:24                                       ` Daniel Shahaf
2020-04-18 16:32                                         ` Cedric Ware
2020-04-20 17:28                                           ` dana [this message]
2020-04-20 22:17                                             ` Cedric Ware
2020-03-15  1:04                       ` Daniel Shahaf
2020-03-13 14:26                   ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E15633-F786-4BB9-8429-F6B848552841@dana.is \
    --to=dana@dana.is \
    --cc=cedric.ware__bml@normalesup.org \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).