From: "Lawrence Velázquez" <larryv@zsh.org>
To: "Bart Schaefer" <schaefer@brasslantern.com>,
"Philippe Altherr" <philippe.altherr@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] NEWS item about the ERR_EXIT fixes
Date: Fri, 09 Dec 2022 01:44:44 -0500 [thread overview]
Message-ID: <46fcb939-0ed9-4b51-959d-67339181e3e3@app.fastmail.com> (raw)
In-Reply-To: <CAH+w=7aH6STxZv5AE9J-FZXRRvd7qu+2jqMJ0hMW0Lj__u2Z3Q@mail.gmail.com>
On Thu, Dec 8, 2022, at 7:24 PM, Bart Schaefer wrote:
> On Thu, Dec 8, 2022 at 1:47 PM Philippe Altherr
> <philippe.altherr@gmail.com> wrote:
>>
>> I couldn't make it shorter than what is in the patch.
>
> I think this is fine. Any opposed?
I think it's overly verbose; NEWS doesn't have to explain how
ERR_EXIT works. Here's a possible alternative:
diff --git a/NEWS b/NEWS
index cdafd1ff5..d8b8687c0 100644
--- a/NEWS
+++ b/NEWS
@@ -4,8 +4,27 @@ CHANGES FROM PREVIOUS VERSIONS OF ZSH
Note also the list of incompatibilities in the README file.
-Changes since 5.8.1
--------------------
+Changes since 5.9
+-----------------
+
+The ERR_EXIT option was refined to be more self-consistent and better
+aligned with the POSIX-2017 specification of `set -e`:
+
+ - Prefixing a function call or anonymous function with `!` now
+ suppresses ERR_EXIT.
+
+ - The `always` command now propagates ERR_EXIT suppression, as other
+ complex commands do.
+
+ - Function calls, anonymous functions, and the `eval`, `.`, and
+ `source` commands no longer propagate ERR_EXIT suppression.
+
+The ERR_RETURN option is now suppressed when a function containing
+a compound sublist (`&&` or `||`) is called from within another compound
+sublist.
+
+Changes from 5.8.1 to 5.9
+-------------------------
zsh 5.9 is dedicated to the memory of Sven Guckes, who was, amongst other
things, a long-time zsh advocate. For more information, see:
--
vq
next prev parent reply other threads:[~2022-12-09 6:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 21:45 Philippe Altherr
2022-12-09 0:24 ` Bart Schaefer
2022-12-09 6:44 ` Lawrence Velázquez [this message]
2022-12-09 9:30 ` Philippe Altherr
2022-12-09 15:17 ` Mikael Magnusson
2022-12-10 7:23 ` Lawrence Velázquez
2022-12-10 7:35 ` Lawrence Velázquez
2022-12-10 11:32 ` Daniel Shahaf
2022-12-10 13:49 ` Philippe Altherr
2022-12-11 3:32 ` Lawrence Velázquez
2022-12-13 0:33 ` Philippe Altherr
2022-12-13 3:05 ` Daniel Shahaf
2022-12-11 3:23 ` Lawrence Velázquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46fcb939-0ed9-4b51-959d-67339181e3e3@app.fastmail.com \
--to=larryv@zsh.org \
--cc=philippe.altherr@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).