From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 12660 invoked from network); 4 Aug 2022 08:55:55 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Aug 2022 08:55:55 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1659603355; b=OKzsehSynud5tCPC3It1+8h6VS/nLAqfspLdWNcv3NFK6XEAMBDtefPh1A8Sp/R2eo14O1yKea 5PtK3V6GNT8R2RQFh6GbbZxHH4PNspLN18tBd3SH7AeYWYG3TGcaEJbmaJPvt5t3pnQgQvJpJ8 Bo7F/u9XTgOslEb/6V10o500jYmJaeYeKYv0ewbVsjki/mdVcgbOQv5mpJ6zQjyLs6oCGgYSTw eIB3/3dovl4WiYvptDJ2fspRn33irnf/ZvjWuaLRasqfWsmfILFLW16b1ADFP4NBpGi18V5q2P RZTP8GnlOI80o1OcO8YKJi5JuFAIsbbNwna82bcfUs77zQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd01005-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.21; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1659603355; bh=nGmJeKsIbSTscw+jtzHjAKbpVqJfq0Uu/B8xZ+ZcSgU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=XwPQRWOZaJXNI80wLUmz25Hk8YabUqG6YmoMrJZzfxazkcK4KiVdfJoS4lmWEEtAvYWMaczcvf hu9Rciiq+CXZ8/RESYk6ufMDOuHEoL45QQn38xDAdrHXJvIWiaNes4JOCWv8quRE6+P3oeVE3r hd0A1jS69fMPsEb6WDdhEO7TmvO8Uw8H66Ak8L3hU4X1UsSLmhIvHiGRdn8BjXyK+zVBXQTtUN 8Fl2Lhfnltd/dQPsmPpe5B6U9sC0t+7aupKsstXQjnQJTRcDsM+Yn6UQ51vaLK8oK+e280eU4r 3PgWeOO6vezQe6pvd905C+918/vtdaEuyZ6G5AhvAFuC7Q==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=XuhnWlQF6G3W8y9kILlht5jKbFYLjz/NmxvhZs2sxT0=; b=ZwYJqvtgfny/wcNH1XBtF8ETxh 0nPZC7pUaCuNOM2iRDC3NrBSxb3xPSHpol/KrnEgy33qJSunmRSfHvn/YVk2BAzGNBIbyyCC5wuFx T+QvXGLB2vQFJZigoGGOq7kF6EnPphcUqtxVyJAWUO3O0vSFT+id8QyTcNyA66azIBv9y+RJn3a0g VrISR92e4d1h4BB3gX7UdFuvr+HiNOPFnRB0iB6Hy0+a9OrBxtVNFf+98aISdx1By4uoDnW3VKXdD wI/ipcvsNXUFljeqbueQ1ubL3+JAwd20ioq+dlLJkCilt3sOJ7P1/Fns7ldylw/o7UMeknzJ1tB72 MS2u0Oww==; Received: from authenticated user by zero.zsh.org with local id 1oJWe1-000CmV-5W; Thu, 04 Aug 2022 08:55:53 +0000 Authentication-Results: zsh.org; iprev=pass (snd01005-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.21; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd01005-bg.im.kddi.ne.jp ([27.86.113.21]:6977 helo=dfmta1009.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1oJWYr-000CKe-Qe; Thu, 04 Aug 2022 08:50:35 +0000 Received: from mail.biglobe.ne.jp by omta1009.biglobe.ne.jp with ESMTP id <20220804085027252.MVWJ.13671.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Thu, 4 Aug 2022 17:50:27 +0900 From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH 3/3] completion: make: fix whitespaces Date: Thu, 4 Aug 2022 17:50:26 +0900 References: <20220730010310.3383526-1-felipe.contreras@gmail.com> <20220730010310.3383526-4-felipe.contreras@gmail.com> To: zsh-workers@zsh.org In-Reply-To: <20220730010310.3383526-4-felipe.contreras@gmail.com> Message-Id: <473642FA-6178-4DD1-8B97-2250B1EED661@kba.biglobe.ne.jp> X-Mailer: Apple Mail (2.3445.104.21) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 50443 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: As this patch shows, _make has some indentation problems (and also lots of other scripts have them). > 2022/07/30 10:03, Felipe Contreras write: > > diff --git a/Completion/Unix/Command/_make b/Completion/Unix/Command/_make > @@ -12,35 +12,35 @@ _make-expandVars() { > > case $rest[2] in > ($) # '$$'. may not appear in target and variable's value > - front=$front\$\$ > - rest=${rest[3,-1]} > - continue > - ;; > + front=$front\$\$ > + rest=${rest[3,-1]} (snip) # I didn't know that indent_style for scripts has changed from # tab to space. I have a vague memory of argument that it's not good to fix indent of lines not related with the real fix because it makes 'git blame' rather useless, and then someone wrote that 'git blame -w' can be used in that case. So, in general, is it better (or not) to apply this type of patch?