From: Kamil Dudka <kdudka@redhat.com>
To: zsh-workers@zsh.org
Subject: infinite recursion when handling the "out of memory" state
Date: Mon, 25 Jan 2016 16:02:50 +0100 [thread overview]
Message-ID: <4775934.DA9sGOASTP@kdudka.brq.redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
If zsh is compiled with multibyte support, handling of the "out of memory"
state does not work well in certain cases -- instead of printing the error
message and exiting, zsh ends up in an infinite recursion and crashes due to
stack overflow.
The memory allocation functions in mem.c use zerr() to print the fatal error
messages. However, zerr() calls zwarning() and transitively mb_niceformat(),
which allocates heap memory (and may call zerr() on failure).
I see three options how to prevent the stack overflow in such cases:
1. avoid using zerr() to print "out of memory" error messages
2. implement zerr() such that it does not trigger heap memory allocation
(I am afraid this is not really possible)
3. introduce a flag that would prevent zerr() from recurring into itself
I have attached a reproducer script. It works reliably if the zsh executable
is linked statically. Otherwise it may happen that the dynamic linker is more
hungry on memory than zsh itself, which would hide the bug.
Originally reported at: https://bugzilla.redhat.com/1300958
Kamil
[-- Attachment #2: oom.zsh --]
[-- Type: application/x-shellscript, Size: 699 bytes --]
next reply other threads:[~2016-01-25 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:02 Kamil Dudka [this message]
2016-01-25 15:31 ` Peter Stephenson
2016-01-25 17:01 ` Kamil Dudka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4775934.DA9sGOASTP@kdudka.brq.redhat.com \
--to=kdudka@redhat.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).