From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Clint Adams <clint@zsh.org>
Cc: zsh-workers@sunsite.dk
Subject: Re: PATCH: (4.0.7) terminfo echo ti args
Date: Thu, 20 Nov 2003 10:31:24 +0100 [thread overview]
Message-ID: <4885.1069320684@gmcs3.local> (raw)
In-Reply-To: <20031119170331.GA13715@scowler.net>
Clint Adams wrote:
> This (except for the ERR define) has been part of the Debian package for
> quite some time now. I imagine that it won't do much for the
> portability problems.
> +/* If ERR isn't defined, we probably have bigger problems,
> + * but try this anyway. */
> +# ifndef ERR
> +# define ERR (-1)
> +# endif
Well, doing that would fix the compile problem that has been mentioned
for FreeBSD and that I have on my Debian machine. Not the nicest way
but it'd work just as long as no system uses something other than -1
for ERR.
The rest of this looks like the 4.1 patch for echoti to take arguments.
It lacks the changes I made in 18626 in response to the thread starting
at 18544. I take it from the subject line that you're suggesting this
is applied to 4.0. I really don't think we should be making changes
like this on the 4.0 branch. Especially not this shortly before a 4.0.8
release. terminfo/termcap are one of the more common causes of
portability problems and 4.0 is at least working at the moment.
Oliver
prev parent reply other threads:[~2003-11-20 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-19 17:03 Clint Adams
2003-11-20 9:31 ` Oliver Kiddle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4885.1069320684@gmcs3.local \
--to=okiddle@yahoo.co.uk \
--cc=clint@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).