From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27937 invoked from network); 20 Nov 2003 09:27:56 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 20 Nov 2003 09:27:56 -0000 Received: (qmail 26982 invoked by alias); 20 Nov 2003 09:27:49 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 19262 Received: (qmail 26918 invoked from network); 20 Nov 2003 09:27:48 -0000 Received: from localhost (HELO sunsite.dk) (127.0.0.1) by localhost with SMTP; 20 Nov 2003 09:27:48 -0000 X-MessageWall-Score: 0 (sunsite.dk) Received: from [193.109.254.211] by sunsite.dk (MessageWall 1.0.8) with SMTP; 20 Nov 2003 9:27:48 -0000 X-VirusChecked: Checked X-Env-Sender: okiddle@yahoo.co.uk X-Msg-Ref: server-23.tower-36.messagelabs.com!1069320467!1953560 X-StarScan-Version: 5.1.13; banners=-,-,- Received: (qmail 3191 invoked from network); 20 Nov 2003 09:27:47 -0000 Received: from iris.logica.co.uk (158.234.9.163) by server-23.tower-36.messagelabs.com with SMTP; 20 Nov 2003 09:27:47 -0000 Received: from gmcs3.local ([158.234.142.61]) by iris.logica.co.uk (8.12.3/8.12.3/Debian -4) with ESMTP id hAK9RkXh002118; Thu, 20 Nov 2003 09:27:46 GMT Received: from gmcs3.local (localhost [127.0.0.1]) by gmcs3.local (8.11.6/8.11.6/SuSE Linux 0.5) with ESMTP id hAK9VO504887; Thu, 20 Nov 2003 10:31:24 +0100 cc: zsh-workers@sunsite.dk X-VirusChecked: Checked X-StarScan-Version: 5.0.7; banners=.,-,- In-reply-to: <20031119170331.GA13715@scowler.net> From: Oliver Kiddle References: <20031119170331.GA13715@scowler.net> To: Clint Adams Subject: Re: PATCH: (4.0.7) terminfo echo ti args Date: Thu, 20 Nov 2003 10:31:24 +0100 Message-ID: <4885.1069320684@gmcs3.local> Clint Adams wrote: > This (except for the ERR define) has been part of the Debian package for > quite some time now. I imagine that it won't do much for the > portability problems. > +/* If ERR isn't defined, we probably have bigger problems, > + * but try this anyway. */ > +# ifndef ERR > +# define ERR (-1) > +# endif Well, doing that would fix the compile problem that has been mentioned for FreeBSD and that I have on my Debian machine. Not the nicest way but it'd work just as long as no system uses something other than -1 for ERR. The rest of this looks like the 4.1 patch for echoti to take arguments. It lacks the changes I made in 18626 in response to the thread starting at 18544. I take it from the subject line that you're suggesting this is applied to 4.0. I really don't think we should be making changes like this on the 4.0 branch. Especially not this shortly before a 4.0.8 release. terminfo/termcap are one of the more common causes of portability problems and 4.0 is at least working at the moment. Oliver