zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <opk@zsh.org>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Feature request: italic style in region_highlight
Date: Tue, 25 May 2021 18:38:59 +0200	[thread overview]
Message-ID: <49048-1621960739.992534@cck-.ZhRR.5MFR> (raw)
In-Reply-To: <CAHLkEDs5xV9f-iv6WAmjnYp2FP6wZm5AL_0+FwmJwWwAJjYrZw@mail.gmail.com>

On 20 May, Marlon Richert wrote:
> Did this discussion and the one in workers/47491 ever result in
> anything? Is it still on the table?

I did apply patch 47510 which corresponds to possibility (1) from
workers/47491. That does free the necessary two bits for italic to be
possible. I was inclined to give that some time before reusing the
bits in case it needs to be reverted.

I still think possibility (2) from 47491 is worth pursuing, mainly
because the associated refactoring would likely simplify a good chunk
of code. There's probably demand for supporting further attributes. But
I'm not sure whether there are any I'd have much use for. Faint and
dim don't seem to be supported in any of my terminals and are possibly
often only equivalent to a different colour. <blink> in HTML was derided
for a good reason. reverse as distinct from standout should probably be
supported.

Actually adding the support for just italic should now be relatively
straightforward because it is mostly copy and paste from existing
attributes. %A{italic} rather than %O would be slightly more effort but
is, I think, nicer. If we do end up having to revert 47510, possibility
(3) is at least definitely possible as a last resort even though it'd
make the code uglier.

Oliver


  reply	other threads:[~2021-05-25 16:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30  1:29 Sebastian Gniazdowski
2019-12-30 10:16 ` Roman Perepelitsa
2019-12-30 16:07   ` Bart Schaefer
2019-12-30 16:26     ` Roman Perepelitsa
2020-01-01  0:07       ` Bart Schaefer
2020-01-02 19:18         ` Oliver Kiddle
2020-01-02 19:45           ` Roman Perepelitsa
2020-01-03  2:30             ` Bart Schaefer
2020-01-03 20:28               ` Daniel Shahaf
2021-05-20 13:33                 ` Marlon Richert
2021-05-25 16:38                   ` Oliver Kiddle [this message]
2021-05-25 20:50                     ` Marlon Richert
2021-05-25 20:56                       ` Bart Schaefer
2021-05-27  8:04                         ` Marlon Richert
2021-05-25 17:28                 ` Bart Schaefer
2021-05-25 22:43                   ` Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49048-1621960739.992534@cck-.ZhRR.5MFR \
    --to=opk@zsh.org \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).