From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30768 invoked from network); 25 May 2021 16:39:37 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 25 May 2021 16:39:37 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID: Content-Type:MIME-Version:Subject:To:References:From:In-reply-to:cc:Reply-To: Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=G+3pTNod0RmIzPPgD/t2XwgYKkRkBOTQFUG4ZQ6fYCs=; b=EKSEE/iX7H1g/cNmM8+Hg3g2ub PXdNhEwJLlpusUmZtTgTzFyXZY499JKrfMK/zaZYSPHoILyt4iBtDgKTueBIZsudSvyyIkEwK9Vfq TSwszQPHA33rmKgoZJana7SG7LTaA7WtxG70JzAa2U+lk6VB64PqHPKLfsvylYR3OVWpRxtQJ7Z+E 1W0KOfc39t9Btv11ulaXCYkhHrULAmhNG3sQFXZk6oHlIjY3wHacb3F0yuaSEzlJBH48AtTz3IZI9 O4Xm5pCqyO/OVfKEqT/ybaqPNzPvN3PBJ2yawBqD+GHPXNPIWgqYmebCKL2RyGnla25WUR7EkQyZ2 G6Srm0xA==; Received: from authenticated user by zero.zsh.org with local id 1lla5g-000JOu-MV; Tue, 25 May 2021 16:39:36 +0000 Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lla5A-000J5n-Ay; Tue, 25 May 2021 16:39:04 +0000 Received: from [192.168.178.21] (helo=hydra) by mail.kiddle.eu with esmtp(Exim 4.94.2) (envelope-from ) id 1lla55-000Cl7-W8; Tue, 25 May 2021 18:39:00 +0200 cc: Zsh hackers list In-reply-to: From: Oliver Kiddle References: <40813-1577992732.270919@2Jfy.SNk-.4lUU> <20200103202807.cxocci634aksqwot@tarpaulin.shahaf.local2> To: Marlon Richert Subject: Re: Feature request: italic style in region_highlight MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <49047.1621960739.1@hydra> Date: Tue, 25 May 2021 18:38:59 +0200 Message-ID: <49048-1621960739.992534@cck-.ZhRR.5MFR> X-Seq: 48923 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 20 May, Marlon Richert wrote: > Did this discussion and the one in workers/47491 ever result in > anything? Is it still on the table? I did apply patch 47510 which corresponds to possibility (1) from workers/47491. That does free the necessary two bits for italic to be possible. I was inclined to give that some time before reusing the bits in case it needs to be reverted. I still think possibility (2) from 47491 is worth pursuing, mainly because the associated refactoring would likely simplify a good chunk of code. There's probably demand for supporting further attributes. But I'm not sure whether there are any I'd have much use for. Faint and dim don't seem to be supported in any of my terminals and are possibly often only equivalent to a different colour. in HTML was derided for a good reason. reverse as distinct from standout should probably be supported. Actually adding the support for just italic should now be relatively straightforward because it is mostly copy and paste from existing attributes. %A{italic} rather than %O would be slightly more effort but is, I think, nicer. If we do end up having to revert 47510, possibility (3) is at least definitely possible as a last resort even though it'd make the code uglier. Oliver