From: dana <dana@dana.is>
To: Aurélien <orel_jf@yahoo.fr>
Cc: Zsh hackers list <zsh-workers@zsh.org>,
Daniel Shahaf <d.s@daniel.shahaf.name>
Subject: Re: help for writing GNU stow completion
Date: Tue, 15 Oct 2019 20:14:11 -0500 [thread overview]
Message-ID: <4A483767-CCCF-4F28-BC47-9717F5139A2F@dana.is> (raw)
In-Reply-To: <3d6745b1-b408-bbf3-4fd7-aeff1271f34e@yahoo.fr>
On 13 Oct 2019, at 12:51, Aurélien <orel_jf@yahoo.fr> wrote:
> Following these exchanges, I modified the pull request to come back to a
> version that does not use "eval" (see:
> https://github.com/zsh-users/zsh/pull/36).
I think your most recent change looks OK, as far as the evaluation stuff is
concerned. I noticed some other minor issues, though. Not actually sure what
the etiquette is here, but since the original patch was done on GitHub i've
left my comments there
dana
prev parent reply other threads:[~2019-10-16 1:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1e5195bb-3126-8d0c-8a6a-1f5a5fd2a6c0@yahoo.fr>
[not found] ` <BAE67462-BF39-481A-BCD6-DE288FE6CC92@dana.is>
[not found] ` <d30637f3-cbbb-8b93-35f2-421a1a99e1dc@yahoo.fr>
2019-08-17 17:53 ` Daniel Shahaf
2019-08-17 21:44 ` dana
2019-08-20 17:45 ` Aurélien
2019-08-25 1:14 ` dana
2019-10-13 17:51 ` Aurélien
2019-10-16 1:14 ` dana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A483767-CCCF-4F28-BC47-9717F5139A2F@dana.is \
--to=dana@dana.is \
--cc=d.s@daniel.shahaf.name \
--cc=orel_jf@yahoo.fr \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).