From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 4e0a66af for ; Wed, 16 Oct 2019 01:14:51 +0000 (UTC) Received: (qmail 24697 invoked by alias); 16 Oct 2019 01:14:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44837 Received: (qmail 18993 invoked by uid 1010); 16 Oct 2019 01:14:46 -0000 X-Qmail-Scanner-Diagnostics: from mail-io1-f42.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25601. spamassassin: 3.4.2. Clear:RC:0(209.85.166.42):SA:0(-1.9/5.0):. Processed in 0.785135 secs); 16 Oct 2019 01:14:46 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.42 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ONWzkFlT3kXpvKfMT7XE1eUPt9a17jr5QHDu1eeqOrE=; b=E7ufDAU8iBrwd5yi+yC7EQ2EsYMRcIOGjdCbbql0cpwjeT5D4GvKm0lIh2aN9Z/twB L2BgVHKYEJBIEHUjciIavs9t7JaQr+v1cRFhGa5oEwFWKuDH7w56yMHkVkeG3opPPfiU LV44dpesaLk/EwOZjAyMFZwbiZRrQgE4T2T72ojbVpVb93frrNd2PWlAq90Z7Nt3i9wP kqINcoCZl4Tyj46I/VElxXhhUz3UBhFnAncMW1dgeGlKXWl1DGUFUq30WsTPQaNlYNuq txcZjpJ0xvIsMpyRSMrEGqI/ZgOCAQT8OanDOrMvsrRmE2XL73g/VWcyHZHzU2soFaMI 1xbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ONWzkFlT3kXpvKfMT7XE1eUPt9a17jr5QHDu1eeqOrE=; b=U4jNxWNw7MyWP2pjBGjZ8ii0kHvUgollVRaMbw251U7Ek053z34ZG4xgv2X8Wqkp19 5UvbnNRJRETOFHYLgSYUNM6s5A0QeXl2r/rFIxCarw9ApoWB38PgmyXd5ud4X6c68Rl0 FYs0tXEejWqZ88NnlZ0Kdp5UHBvj5dNR5zme7r+a4Wd9/d2Oiwcz1oKkXnvqqYKRgim6 k8YznjrfN34WSb6SA4LmTWlfvJ/JahgXBu8AZZIIxk1m8utJWWTj3c7NxoP7gtnImU60 i8CDrS8jM9XefZ4hKt97mDvz3Q+1Wx3vfluAA7R9OM0Y4d7yhBosV6Gas8HiOIvMlVCE gpEw== X-Gm-Message-State: APjAAAVRUPnwTH9mL4puDyW7uX/jN46wrW4r0YDVSQp7e16/8qJjZ0u3 vom2z3pGXMl8f4pcB27ekNy7rQ== X-Google-Smtp-Source: APXvYqyv3SqjuOpknXR/mM9k4Ilnx08KJvEwLfCzG8fCPpkWN1BaU0+RhT+qQOP61RhXK0QZ1+oJYw== X-Received: by 2002:a92:7ed7:: with SMTP id q84mr10292117ill.237.1571188452759; Tue, 15 Oct 2019 18:14:12 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: help for writing GNU stow completion From: dana In-Reply-To: <3d6745b1-b408-bbf3-4fd7-aeff1271f34e@yahoo.fr> Date: Tue, 15 Oct 2019 20:14:11 -0500 Cc: Zsh hackers list , Daniel Shahaf Content-Transfer-Encoding: quoted-printable Message-Id: <4A483767-CCCF-4F28-BC47-9717F5139A2F@dana.is> References: <1e5195bb-3126-8d0c-8a6a-1f5a5fd2a6c0@yahoo.fr> <0618d7fc-5334-4e51-829a-8684a81744c1@www.fastmail.com> <558a3ff8-d6f1-9ab0-3387-a17ca5e0e75b@yahoo.fr> <707548C8-840F-449C-BCE4-3E406F6FACD2@dana.is> <3d6745b1-b408-bbf3-4fd7-aeff1271f34e@yahoo.fr> To: =?utf-8?B?QXVyw6lsaWVu?= X-Mailer: Apple Mail (2.3445.104.11) On 13 Oct 2019, at 12:51, Aur=C3=A9lien wrote: > Following these exchanges, I modified the pull request to come back to = a > version that does not use "eval" (see: > https://github.com/zsh-users/zsh/pull/36). I think your most recent change looks OK, as far as the evaluation stuff = is concerned. I noticed some other minor issues, though. Not actually sure = what the etiquette is here, but since the original patch was done on GitHub = i've left my comments there dana