From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20278 invoked from network); 4 Apr 2022 08:34:54 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Apr 2022 08:34:54 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1649061294; b=bETBsh1xoqKA54I55nbVDTIYMOmx/MdMxWK3itZJZK6Dk5qiaWhF66spawpHrHH0kDLyXNUWGL kqlIMXW4PbRewSlZxjafQ99WL1il3mJp14Ek4/ErklU7GGG9syDfip314utwROA2+ZE5lVxm4x 41YqPYK/lh72IqdvYIFhNr149Sj4/6dXZmjQz509k0TwPKuN5kKfA9Zgx14NjLnkHvPLW2YoH3 QlHULXIWGoqCfb5BJvCDu1HnOQPMRq+Qd5hZseiCVHqViE66i5jKHFiTSpN/9HyrLyst8MWPvW 4vLyR9IUwKLfwlpAlLC+7KkipMdkraDC2oO0b1Qve0XnDw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd00008-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.8; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1649061294; bh=qC+X9ZhYLP9y5wVVQQWlXSXW1XuF6diKMecSESSSgo0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=JGWwRoamx+8K6nVCqPf60WU7hmO+zBkGd88kojWIx4DXirmn0areLEkXyhKSkitkxJloWkyVDy DeB2cgUcGKpwJvD1jHoG21CjpoF+UgdVCV1luEXb7v43Qir/i1iS9Rc0fw/Wi4WGKoqwFlvLXV gXDf6vyQd0uNyvKiah9K0tc2s9w540FcFsbweudlxG0lgVKfIsgduchLlksqge+vZaCUNMNfl8 JAcLRoTxjlVW184Jbhfpy/IQGI56Htu7wK4XlEVW759SwmyS/NiiUrdg1w8cpNSGH8wXGGWUpr 4oEVeCYNBlLLr80JRyWfyeA+KDzYjvD6/jmWhVspNJrnVw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=EeENFGLEi6xAS5Lz3v+vBYrMvNfZ3XqlER3IDBWBa20=; b=NfNAmyNUMnYA52Uph3eIEUaRQP GBxM3r66wgsy+JHG6+7HTibIFfia4beiyqpxTEAiVb2lrOVu9atN+wNCyJxfbpdCRL/YhcNRkko0C +JkL/vQsY5b360PaJRoS1986ugYYR11yAwFp0yatUxcvKk9GnmM3Vo+vvV2CWVlRwQodQSnBoJ3uZ /wU84XZtrtgeLwTWvXd3XJeGv+JPhDSF+UO6czxFO+8sANA2fSXG/gQ/+6xAfYTUc+Sy92np+yp1Z tTMgofDu3v9LuFsgByK/RErb31E7YHyG9/Oku7hg+5nGTYefycQPBp1Qte6zcb2LBEraGF58eVj4U RKwLPLSw==; Received: from authenticated user by zero.zsh.org with local id 1nbIAm-000LjU-K1; Mon, 04 Apr 2022 08:34:52 +0000 Authentication-Results: zsh.org; iprev=pass (snd00008-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.8; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd00008-bg.im.kddi.ne.jp ([27.86.113.8]:35041 helo=dfmta0002.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1nbIAD-000LQQ-Dk; Mon, 04 Apr 2022 08:34:19 +0000 Received: from mail.biglobe.ne.jp by omta0002.biglobe.ne.jp with ESMTP id <20220404083410571.DNAX.93638.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Mon, 4 Apr 2022 17:34:10 +0900 From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: Hang in E01 due to zpty on OpenBSD Date: Mon, 4 Apr 2022 17:34:09 +0900 References: To: zsh-workers@zsh.org In-Reply-To: Message-Id: <4BCAE950-2D78-415A-88C3-8362946DC74C@kba.biglobe.ne.jp> X-Mailer: Apple Mail (2.3445.104.21) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 49984 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > 2022/04/04 12:49, Matthew Martin wrote: >=20 > OpenBSD has gutted the pty route and strongly prefers openpty over > posix_openpt. Is there a correct way link the zpty module against > libutil? Please try the following patch. Replace the pattern (in configure.ac) openbsd*) by openbsd7*) or such if openpty() should be used only on specific versions of = OpenBSD. diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c index dfd2a2a7a..cdab1d8e1 100644 --- a/Src/Modules/zpty.c +++ b/Src/Modules/zpty.c @@ -249,6 +249,28 @@ get_pty(int master, int *retfd) return 0; } =20 +/* openpty() is prefered on OpenBSD */ +#elif defined(__OpenBSD__) && defined(HAVE_OPENPTY) + +#include + +static int +get_pty(int master, int *retfd) +{ + static int mfd, sfd; + + if (master) { + if (openpty(&mfd, &sfd, NULL, NULL, NULL) =3D=3D -1) + return 1; + + *retfd =3D mfd; + return 0; + } + + *retfd =3D sfd; + return 0; +} + #else /* No /dev/ptmx or no pt functions */ =20 static int diff --git a/configure.ac b/configure.ac index 8bba78c56..6aae71300 100644 --- a/configure.ac +++ b/configure.ac @@ -2441,6 +2441,18 @@ int ptsname();]], = [[]])],[ac_cv_use_dev_ptmx=3Dno],[ac_cv_use_dev_ptmx=3Dyes])]) fi fi =20 +dnl On (some) OpenBSD, it seems openpty() is the only reliable way to = get pty. +AH_TEMPLATE([HAVE_OPENPTY], +[Define to 1 if openpt() is available on OpenBSD]) +case "$host_os" in + openbsd*) + AC_SEARCH_LIBS(openpty, util) + if test x$ac_cv_search_openpty !=3D xno; then + AC_DEFINE(HAVE_OPENPTY) + fi + ;; +esac + dnl ----------------- dnl multibyte support dnl -----------------