zsh-workers
 help / color / mirror / code / Atom feed
From: "Lawrence Velázquez" <vq@larryv.me>
To: Ray Andrews <rayandrews@eastlink.ca>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: hist: remove wrong NULL terminator
Date: Fri, 9 Jan 2015 13:36:01 -0500	[thread overview]
Message-ID: <4CD0C50B-63EB-4DDA-BD79-DF5763DC0458@larryv.me> (raw)
In-Reply-To: <6787593B-FA2B-4666-9F2B-23A43DCFBDFF@larryv.me>

On Jan 9, 2015, at 1:33 PM, Lawrence Velázquez <vq@larryv.me> wrote:

>    % git blame -L 2179,+6 Src/hist.c(git:master)
>    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2179)      *rptr++ = *ptr;
>    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2180)     *rptr++ = '\'';
>    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2181)     *rptr++ = 0;
>    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2182)     str[1] = NULL;
>    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2183)     return 0;
>    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2184) }
>    % git show --shortstat e74702b4(git:master)
>    commit e74702b467171dbdafb56dfe354794a212e020d9
>    Author: Tanaka Akira <akr@users.sourceforge.net>
>    Date:   Thu Apr 15 18:05:38 1999 +0000
> 
>        Initial revision
> 
>     354 files changed, 66043 insertions(+)

Badly-edited paste. In the interests of correctness:

    % git blame -L 2179,+6 Src/hist.c
    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2179)      *rptr++ = *ptr;
    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2180)     *rptr++ = '\'';
    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2181)     *rptr++ = 0;
    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2182)     str[1] = NULL;
    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2183)     return 0;
    e74702b4 (Tanaka Akira 1999-04-15 18:05:38 +0000 2184) }
    % git show --shortstat e74702b4
    commit e74702b467171dbdafb56dfe354794a212e020d9
    Author: Tanaka Akira <akr@users.sourceforge.net>
    Date:   Thu Apr 15 18:05:38 1999 +0000

        Initial revision

     354 files changed, 66043 insertions(+)

vq

  reply	other threads:[~2015-01-09 18:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 12:43 Mikael Magnusson
2015-01-09 17:45 ` Ray Andrews
2015-01-09 18:33   ` Lawrence Velázquez
2015-01-09 18:36     ` Lawrence Velázquez [this message]
2015-01-09 19:38   ` Mikael Magnusson
2015-01-09 21:39     ` Ray Andrews
2015-01-09 22:30       ` Peter Stephenson
2015-01-09 23:39         ` Ray Andrews
2015-01-10  0:39           ` Bart Schaefer
2015-01-10  7:45             ` Ray Andrews
2015-01-10 22:04               ` Lawrence Velázquez
2015-01-10 22:50                 ` Ray Andrews
2015-01-11  1:58                   ` Bart Schaefer
2015-01-11  5:46                     ` Ray Andrews
2015-01-11  7:10                       ` Floating point modulus Bart Schaefer
2015-01-11 17:33                         ` Peter Stephenson
2015-01-11 19:25                           ` Bart Schaefer
2015-01-11 19:25                         ` Ray Andrews
2015-01-11 20:00                           ` Bart Schaefer
2015-01-11 20:58                             ` Ray Andrews
2015-01-11 21:34                               ` Peter Stephenson
2015-01-12  0:18                                 ` Ray Andrews
2015-01-12 10:03                                   ` Peter Stephenson
2015-01-11 19:36                         ` Bart Schaefer
2015-01-11 20:01                           ` Peter Stephenson
2015-01-11 20:04                             ` Bart Schaefer
2015-01-11 20:25                               ` Peter Stephenson
2015-01-12  0:02                                 ` Ray Andrews
2015-01-12  2:23                                   ` Bart Schaefer
2015-01-12  2:46                                 ` Bart Schaefer
2015-01-12  9:56                                   ` Peter Stephenson
2015-01-12 13:49                                     ` Peter Stephenson
2015-01-12 16:35                                     ` Bart Schaefer
2015-01-12 16:45                                       ` Peter Stephenson
2015-01-12 11:36                           ` Vincent Lefevre
2015-01-10  7:08 ` PATCH: hist: remove wrong NULL terminator Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD0C50B-63EB-4DDA-BD79-DF5763DC0458@larryv.me \
    --to=vq@larryv.me \
    --cc=rayandrews@eastlink.ca \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).