From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] allocate origline by ztrdup(), not by dupstring()
Date: Sun, 21 Jun 2015 20:53:49 +0900 [thread overview]
Message-ID: <4F8A1056-198B-4CF1-A167-7C3060F77B10@kba.biglobe.ne.jp> (raw)
In-Reply-To: <24973.1434473665@thecus.kiddle.eu>
2015/06/17 01:54, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> This part is run when pressing backspace, it seems to always be the case
> that origline == u->origline before this block runs. So it is copying freed
> memory.
Backspace (in the interactive mode) seems to work as expected with the
following patch. Does this look reasonable?
diff --git a/Src/Zle/complist.c b/Src/Zle/complist.c
index 0f73181..ccee9a7 100644
--- a/Src/Zle/complist.c
+++ b/Src/Zle/complist.c
@@ -2655,7 +2655,7 @@ domenuselect(Hookdef dummy, Chdata dat)
s->nbrbeg = nbrbeg;
s->nbrend = nbrend;
s->nmatches = nmatches;
- s->origline = origline;
+ s->origline = dupstring(origline);
s->origcs = origcs;
s->origll = origll;
s->status = dupstring(status);
@@ -2786,7 +2786,7 @@ domenuselect(Hookdef dummy, Chdata dat)
s->nbrbeg = nbrbeg;
s->nbrend = nbrend;
s->nmatches = nmatches;
- s->origline = origline;
+ s->origline = dupstring(origline);
s->origcs = origcs;
s->origll = origll;
s->status = dupstring(status);
next prev parent reply other threads:[~2015-06-21 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 16:37 Jun T.
2015-01-06 18:23 ` Jun T.
2015-06-16 16:54 ` Oliver Kiddle
2015-06-17 16:24 ` Jun T.
2015-06-21 11:53 ` Jun T. [this message]
2015-06-22 8:36 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8A1056-198B-4CF1-A167-7C3060F77B10@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).