From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HTML_MESSAGE,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15293 invoked from network); 2 Jun 2021 03:27:42 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 2 Jun 2021 03:27:42 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1622604462; b=edLc6qu0vmvRNVtBZucKjESR1S9LexkgWPLsfGOWjj7GQTtjiJ1janl9wxxrJsHF1pKdlb0nzy r1PmpmR4yONCVJ2Qm8y0MiaYzChmEL/8ainHf8Dd2UAbnjWX8ODUPjY0NUJ5MVCB6R5CmuQEVZ Quc8iEuJGwunYEc8UT1/+K7sPBsZWlgWMe/bZ+THDnNgMohrWm9KpTxCdSQqml5RZ99AQlhp8t J4+13Mmrv16cnvdsNuSOINwPnCKm/Iv+jy8rdRA1iyAuu2QCfbNpWIcwWG/wjo8SQpjllV2uS1 kfN5rsIsJHL4XVGP0zjbroCffrEbOwJ8ZW8tb3vjpKrwEw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (v055125.ppp.asahi-net.or.jp) smtp.remote-ip=124.155.55.125; dmarc=none header.from=iDaemons.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1622604462; bh=T6BC6mSv+qJnR+hAo6cNgX3QCDgT02XcdB4t62mVffw=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:In-Reply-To:Subject:From:References:To: MIME-Version:Date:Message-ID:DKIM-Signature; b=VU/wrRzZK8NhMex5aYSsUol438YYrukayaSoyfnHXpa1ntw7DY26ijeW6SJY/CPRDOnI0obdxz q+CwECI8RnycAIBff2k490Oe3VvqotwPifLoXhVA41ri6ql1eIG0AOY5ak+NGPRYCKRZrULMbF xhZ99tOpA3xSj+vEPLEAxtktjUQBzLuUuTmgs06IWkBxo99mXK5QDNZw90XAYrxj+n6MUc5EDV QiJZFm9Dgv07v95yrOkxoNtTHsnVbE7alwK23SATES6d35RseUmL3m7HYSjtIX3Ysz9n53Yf37 0r90vM2zmJ01BGEFMDHBvPJCY+SoeGCKGpifh5PNOobZzA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:In-Reply-To:Subject:From :References:To:MIME-Version:Date:Message-ID:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Sw8Iup7g/ep7kf5/+8KHwt3v6vrjgEbXAODkSg71DXQ=; b=gnYuY4xvEtAprPTJoPECFMDEjC 4mqdwWbNatGUmUfppHt02QyLhKoiiNPNu69ctc/ayL3VjsGfEfTjsJHtFkv/pJ6qKNRVuOtfDYXog OP1UjAaSVBMvFuwEafu3TL774MCrDviNpShgS+Hu3wA9tJ8jsh2jqa7lQWPXpxa+SpQb2G8m2HeFI 519F5tbjKFYuylP1SmFci+NneP1DYrqGuTsnpHKbmE7UjKQz8vqVNc8MYpy1BZVhj2+Bral2VFwbW zntyFg0ZzZUEK26YVodZaQOhIgTr7WsWHe7mb0l57BXrY4oFaGTkqvQWTEQIR/y00m1r22ZfaRvNC BTlzK/bw==; Received: from authenticated user by zero.zsh.org with local id 1loHXh-000CyW-Ql; Wed, 02 Jun 2021 03:27:41 +0000 Authentication-Results: zsh.org; iprev=pass (v055125.ppp.asahi-net.or.jp) smtp.remote-ip=124.155.55.125; dmarc=none header.from=iDaemons.org; arc=none Received: from v055125.ppp.asahi-net.or.jp ([124.155.55.125]:61957 helo=mail.musha.org) by zero.zsh.org with esmtp id 1loHXR-000CjT-U8; Wed, 02 Jun 2021 03:27:27 +0000 Received: from [192.168.86.77] (unknown [192.168.11.1]) (Authenticated sender: akinori) by mail.musha.org (Postfix) with ESMTPSA id 4Fvvbb4Zzwz2sH; Wed, 2 Jun 2021 12:27:23 +0900 (JST) Message-ID: <4c036f13-8e41-e7a0-1a02-5591e6f14ade@iDaemons.org> Date: Wed, 2 Jun 2021 12:27:23 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: schaefer@brasslantern.com, zsh-workers@zsh.org References: <92d2b09c-9559-7085-a521-29714e38f02c@iDaemons.org> <20210529114108.GA25290@tarpaulin.shahaf.local2> From: Akinori MUSHA Subject: Re: [PATCH] Set TMPSUFFIX=.zsh in edit-command-line In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h98dK55kKAjRnafl7TO0N26nfGx8HdCRR" X-Seq: 48981 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h98dK55kKAjRnafl7TO0N26nfGx8HdCRR Content-Type: multipart/mixed; boundary="Wy6Wm1JaPmnSAaxeqFruge5sACRm4jmR2"; protected-headers="v1" From: Akinori MUSHA To: schaefer@brasslantern.com, zsh-workers@zsh.org Message-ID: <4c036f13-8e41-e7a0-1a02-5591e6f14ade@iDaemons.org> Subject: Re: [PATCH] Set TMPSUFFIX=.zsh in edit-command-line References: <92d2b09c-9559-7085-a521-29714e38f02c@iDaemons.org> <20210529114108.GA25290@tarpaulin.shahaf.local2> In-Reply-To: --Wy6Wm1JaPmnSAaxeqFruge5sACRm4jmR2 Content-Type: multipart/alternative; boundary="------------VTetjnyr0B1i1tGomwCLkhLo" --------------VTetjnyr0B1i1tGomwCLkhLo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAyMS8wNi8wMSA3OjU0LCBCYXJ0IFNjaGFlZmVyIHdyb3RlOg0KPiBVbmxlc3MgdGhl cmUncyBhbiBpbnRlcm5hbCBidWcgd2l0aCBUTVBTVUZGSVgsIEkgY2FuIG9ubHkgdGhpbmsg b2Ygb25lDQo+IHdheSB0aGlzIHBhdGNoIGNvdWxkIGdvIHdyb25nLCBhbmQgaXQncyBwcmV0 dHkgb2JzY3VyZToNClRoYW5rcyBmb3IgdGhlIGNvbnNpZGVyYXRpb24uDQo+IFN1cHBvc2Ug SSBoYXZlIGEgInNtYXJ0IGVkaXRvciIgdGhhdCBhdHRlbXB0cyB0byBkZWNpZGUgd2hhdCBw cm9ncmFtDQo+IHRvIHJ1biBiYXNlZCBvbiBmaWxlIGV4dGVuc2lvbiAob3BlbnMgLnhscyBh cyBhIHNwcmVhZHNoZWV0LCAuZG9jIHdpdGgNCj4gYSB3b3JkIHByb2Nlc3NvciwgZXRjLikg IFN1cHBvc2UgZnVydGhlciB0aGF0IHRoaXMgImVkaXRvciIgb3BlbnMNCj4gZmlsZXMgZW5k aW5nIGluICIucGVybCIsICIuenNoIiwgIi5zaCIsIGV0Yy4gYnkgcnVubmluZyB0aGUNCj4g Y29ycmVzcG9uZGluZyBpbnRlcnByZXRlci4gIE9vcHMsIEkndmUganVzdCBleGVjdXRlZCB0 aGUgY29tbWFuZCBsaW5lDQo+IEkgbWVhbnQgdG8gZWRpdC4NCj4NCj4gVGhpcyBpcyBub3Qg ZW50aXJlbHkgZmFyLWZldGNoZWQsIGlmIHlvdSdyZSBvbiBhIE1hYyBhbmQgaGF2ZSBYQ29k ZQ0KPiBmdWxseSBpbnN0YWxsZWQsICJvcGVuIC90bXAvYmxhYmxhaC56c2giIG1heSBhY3R1 YWxseSBydW4genNoLg0KPg0KPiBJcyB0aGlzIHdvcnRoIHdvcnJ5aW5nIGFib3V0Pw0KDQpB dCBsZWFzdCBpdCBkb2VzIG5vdCByZXByb2R1Y2Ugb24gbXkgTWFjLCB3aGVyZSBYY29kZSBp cyBvcGVuZWQgZm9yIA0KZWRpdGluZyB0aGUgc2NyaXB0LsKgIE9uIFVidW50dSBEZXNrdG9w LCAuenNoIGlzIGFzc29jaWF0ZWQgd2l0aCBnZWRpdCANCmJ5IGRlZmF1bHQuwqAgSWYgb25l IGRhcmVzIHRvIGNoYW5nZSB0aGF0IHRvIG1ha2UgZG91YmxlLWNsaWNraW5nIGluIA0KZ2Vu ZXJhbCB1bnNhZmUgYW5kIHRoZW4gc2V0IEVESVRPUiB0byBvcGVuL3N0YXJ0IGFzIHdlbGws IEkgc2F5IHRoZXkgYXJlIA0Kc2hvb3RpbmcgdGhlaXIgb3duIGZvb3QuDQoNCi0tIA0KDQpB a2lub3JpIE1VU0hBIC9odHRwczovL2FraW5vcmkub3JnLw0KDQo= --------------VTetjnyr0B1i1tGomwCLkhLo Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 2021/06/01 7:54, Bart Schaefer wrote: 
Unless there's an internal b=
ug with TMPSUFFIX, I can only think of one
way this patch could go wrong, and it's pretty obscure:
Thanks for the consideration.
Suppose I have a "smart edit=
or" that attempts to decide what program
to run based on file extension (opens .xls as a spreadsheet, .doc with
a word processor, etc.)  Suppose further that this "editor" opens
files ending in ".perl", ".zsh", ".sh", etc. by running the
corresponding interpreter.  Oops, I've just executed the command line
I meant to edit.

This is not entirely far-fetched, if you're on a Mac and have XCode
fully installed, "open /tmp/blablah.zsh" may actually run zsh.

Is this worth worrying about?

At least it does not reproduce on my Mac, where Xcode is opened for editing the script.=C2=A0 On Ubuntu Desktop, .zsh is associat= ed with gedit by default.=C2=A0 If one dares to change that to make double-clicking in general unsafe and then set EDITOR to open/start as well, I say they are shooting their own foot.

-- 
Akinori MUSHA / https://akinori.org/
--------------VTetjnyr0B1i1tGomwCLkhLo-- --Wy6Wm1JaPmnSAaxeqFruge5sACRm4jmR2-- --h98dK55kKAjRnafl7TO0N26nfGx8HdCRR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wmMEABEIACMWIQQIHQmcFwWGHUtwsEqSC+/Hn9nh7gUCYLb6mwUDAAAAAAAKCRCSC+/Hn9nh7gY3 AKDRz0o+0RdCWvSgYglXiu382knGpgCcCGN+BPHSkxAoUoOLyyLne1d1gvA= =wpMk -----END PGP SIGNATURE----- --h98dK55kKAjRnafl7TO0N26nfGx8HdCRR--