From: Dirus <Dirus@Programmer.net>
To: zsh-workers@sunsite.dk
Cc: Oliver Kiddle <okiddle@yahoo.co.uk>
Subject: Re: prompt themes
Date: Wed, 04 Jun 2003 06:01:44 -0700 [thread overview]
Message-ID: <5.2.1.1.0.20030604050554.025f6070@pop1.mail.com> (raw)
In-Reply-To: <3274.1054719715@gmcs3.local>
At 02:41 AM 6/4/2003, Oliver wrote:
>Dirus wrote:
> > prompt_X_preview doesn't print the first or last blank line. This means
> > the person writing the prompt theme would have to print the blank lines
> > between sample settings without printing the first or last. Whoever is
>
>I'm not quite sure which blank lines you're talking about.
It's not really much to complain about, it just seems counter
intuitive... any theme with a prompt_X_preview function, will look
something like this:
preview prompt
print blank line
preview prompt
print blank line
preview prompt
and promptinit's prompt function will add the first and last blank line.
><snip> It should
>probably also do a preview even if there isn't a prompt_X_preview function
>- there isn't for most.
The problem here is we don't know how many parameters the themes
take. Some might take 2 colors, others 4... and even some such as the
adam2 prompt theme take an '8bit' parameter. Perhaps it would be best to
simply add a list of previews those that could use one, it wouldn't take
more than a couple minutes to find a couple settings for each that look decent.
> > Ideally prompt_X_preview would look like this:
> > prompt_X_preview() {
> > reply=' singleparameter "param1 param2" "param1 param2" '
> > }
>
>Or, since it is an array,
> reply=( singleparameter "param1 param2" "param1 param2" )
Oh hmm, yes that is better, and it would save a '(z)'.
> > Also prompt_X_help could also be changed to set $reply for consistency
> sake.
>
>I'm less convinced by that idea. There's not really any code that can
>be factored out and it wouldn't make the functions any simpler.
I see your point. Using cat is pretty straight forward, and I am happy to
leave it alone. :) The only advantage to using $REPLY here would be that
if you intended on using the help string without directly echoing it to the
screen. Perhaps for some reason you wanted to format it for a menu based
prompt selector where you only have a set space to squish the help text
into, and even then you could probably work around it.
> > Anyone interested in seeing this? Is it best to just send the diffs to
> the
> > mailing list? There would be a lot of them, one for each prompt theme and
> > one for promptinit.
>
>Just send a diff.
Ok. Will do.
>There's probably quite a few aspects of the prompt theming that could
>be improved. Making colour schemes independent of specific fonts would
>be one example. <snip>
Maybe you mean making color schemes independent of specific themes?
One problem I noticed the other day is if one prompt sets PS3, PS4, or
RPS1, then those vars won't get reset when changing prompts, even when
setting the prompt to "off". A good example here is the walters theme and
its RPS1 setting, it will follow you around when you change prompts.
><snip> Perhaps sorting through the distributed themes too: it
>isn't ideal that many don't work right unless your use some peculiar
>font and terminal emulator.
There do seem to be some problems with the distributed themes descriptions
too, for example adam1 (correct me if I'm wrong) says it requires an 8 bit
font when it doesn't. As for requiring an old school terminal type (8 bit)
font, some fancy things such as the connecting lines just can't be done
with a 7 bit font. Perhaps it would be best to set up the prompt themes so
they do not use 8 bit font characters unless specified. On the other hand
we could try to parse the $TERM to make an educated guess, but it probably
couldn't be done properly.
-Dirus
next prev parent reply other threads:[~2003-06-04 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-03 16:55 Dirus
2003-06-04 9:41 ` Oliver Kiddle
2003-06-04 13:01 ` Dirus [this message]
2003-06-04 15:01 ` Oliver Kiddle
2003-06-04 17:21 ` Bart Schaefer
[not found] <6134254DE87BD411908B00A0C99B044F03A0B5FA@mowd019a.mow.siemens.ru>
[not found] ` <1030123180207.ZM12877@candle.brasslantern.com>
[not found] ` <20030124211240.GD6160@io.com>
2003-02-03 11:24 ` Prompt themes Clemens Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.2.1.1.0.20030604050554.025f6070@pop1.mail.com \
--to=dirus@programmer.net \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).