From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 2471 invoked from network); 11 Apr 2021 20:23:36 -0000
Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368)
  by inbox.vuxu.org with ESMTPUTF8; 11 Apr 2021 20:23:36 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org;
	s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:
	List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID:
	Content-Type:MIME-Version:Subject:To:References:From:In-reply-to:cc:Reply-To:
	Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From:
	Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID;
	bh=Sna6RD5QSQP875Qales9aBJ3BxzZ9g4u2pVpfRIiVEY=; b=LpnLJq0wg5pgA53ZMlgRXp1j8j
	UpD0zJ02zJ0o7uJHlcteQP9VLJRTTpgBtYV1fmPecxcU4ELsDXrneKwvZ3TO07TarWFzmLb7xA/KL
	l8iPuhMU7tDCBBvANKuYLjWNWI9ManaCcAr2LcKnNk0sS0JQAgXetaN2VoC+ObhRY6rX36nOj9Hou
	dzT80GYiB8/HEeBZGI7+iITjfIM8pPRfvZuFUVa7etUGx9c9FNfcJBbdo7YS5KqF8er4BG+rn6WzR
	uEMUrvfOWWAHr3byQ5dDUscfKmkk0xkoyRrXc9KMoestvVg+E0saZnxJrFQUfTfSmAslmoJGpQ19W
	ovU+S6ew==;
Received: from authenticated user by zero.zsh.org with local 
	id 1lVgcJ-0006H1-0A; Sun, 11 Apr 2021 20:23:35 +0000
Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)
	id 1lVgc5-00064L-5v; Sun, 11 Apr 2021 20:23:21 +0000
Received: from [192.168.178.21] (helo=hydra)
	by mail.kiddle.eu with esmtp(Exim 4.93.0.4)
	(envelope-from <opk@zsh.org>)
	id 1lVgc4-000D1e-BX; Sun, 11 Apr 2021 22:23:20 +0200
cc: Zsh hackers list <zsh-workers@zsh.org>
In-reply-to: <YHFkB2PYXxZ2kIm0@prometheus.u-strasbg.fr>
From: Oliver Kiddle <opk@zsh.org>
References: <YHCv4PKK/2ah9s32@prometheus.u-strasbg.fr> <84376-1618005187.938917@aiYa.Xwq7.uanX> <YHFkB2PYXxZ2kIm0@prometheus.u-strasbg.fr>
To: Marc Chantreux <eiro@phear.org>
Subject: Re: 2 new patches for _surfraw
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <50072.1618172600.1@hydra>
Date: Sun, 11 Apr 2021 22:23:20 +0200
Message-ID: <50073-1618172600.354479@MZYm.HwWc.l_LS>
X-Seq: 48506
Archived-At: <https://zsh.org/workers/48506>
X-Loop: zsh-workers@zsh.org
Errors-To: zsh-workers-owner@zsh.org
Precedence: list
Precedence: bulk
Sender: zsh-workers-request@zsh.org
X-no-archive: yes
List-Id: <zsh-workers.zsh.org>
List-Help: <mailto:sympa@zsh.org?subject=help>
List-Subscribe: <mailto:sympa@zsh.org?subject=subscribe%20zsh-workers>
List-Unsubscribe: <mailto:sympa@zsh.org?subject=unsubscribe%20zsh-workers>
List-Post: <mailto:zsh-workers@zsh.org>
List-Owner: <mailto:zsh-workers-request@zsh.org>
List-Archive: <http://www.zsh.org/sympa/arc/zsh-workers>

Marc Chantreux wrote:
> +++ b/Completion/Unix/Command/_surfraw
>  #compdef surfraw sr
> +# vim: et ts=2

We have a .editorconfig file in the root of the source tree that
declares this in an editor neutral manner. A plugin for vim exists to
use it. While I do use vim, I don't have, e.g. less configured for a
tabsize of 2. The expandtab option is fine but I go with shiftwidth=2
and leave the tabsize at the default 8.
Your patch even looks like you've fixed the tabs with the equivalent of
expand -t2

I have pushed the various patches including whitespace fixups. If
anything seems missing, let me know. Preferably pull from git for any
further patches to ensure they're against the latest state of HEAD.

Thanks

Oliver